This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: 64-bit support for srec
- From: Alan Modra <amodra at gmail dot com>
- To: Mike Stump <mikestump at comcast dot net>
- Cc: binutils at sourceware dot org
- Date: Thu, 2 Feb 2012 13:52:39 +1030
- Subject: Re: 64-bit support for srec
- References: <3A288B3F-CBD9-4700-9C30-BCFE721F4B72@comcast.net>
On Wed, Feb 01, 2012 at 03:55:11PM -0800, Mike Stump wrote:
> --- 897,907 ----
> else if ((section->lma + offset + bytes_to_do - 1) <= 0xffffff
> && tdata->type <= 2)
> tdata->type = 2;
> ! else if ((section->lma + offset + bytes_to_do - 1) <= 0xffffffff
> ! && tdata->type <= 2)
Probably ought to be <= 3 here. Presumably the idea of the existing
code is that once you've used S3 records, don't drop back to S2.
> + case 4:
> + TOHEX (dst, (address >> 56), check_sum);
> + dst += 2;
What if "address" is only a 32-bit type? I think you need to
conditionalize all your new code on BFD64. And it would be sad if we
can't read back our own output..
--
Alan Modra
Australia Development Lab, IBM