This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] BFD linker support for x86 nacl targets
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Thomas Schwinge <thomas at codesourcery dot com>
- Cc: Roland McGrath <mcgrathr at google dot com>, binutils at sourceware dot org, David Sehr <sehr at google dot com>, Andreas Schwab <schwab at linux-m68k dot org>
- Date: Thu, 7 Jun 2012 08:45:51 -0700
- Subject: Re: [PATCH] BFD linker support for x86 nacl targets
- References: <x57j398pzkrw.fsf@frobland.mtv.corp.google.com> <m28vhmxr3v.fsf@igel.home> <87mx4fkucu.fsf@schwinge.name>
On Thu, Jun 7, 2012 at 8:35 AM, Thomas Schwinge <thomas@codesourcery.com> wrote:
> Hi!
>
> On Mon, 23 Apr 2012 20:03:48 +0200, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Committed as obvious.
>>
>> Andreas.
>>
>> 2012-04-23 ?Andreas Schwab ?<schwab@linux-m68k.org>
>>
>> ? ? ? * ld-pie/pie.exp: Remove extra braces.
>
> ... and another one where I can't but think that is was not intentional:
>
> | diff --git a/binutils/testsuite/binutils-all/i386/i386.exp b/binutils/testsuite/binutils-all/i386/i386.exp
> | index 5b33e67..d06501a 100644
> | --- a/binutils/testsuite/binutils-all/i386/i386.exp
> | +++ b/binutils/testsuite/binutils-all/i386/i386.exp
> | @@ -17,7 +17,8 @@
> |
> | ?if {!([istarget "i*86-*-linux*"]
> | ? ? ? ?|| [istarget "i*86-*-gnu*"]
> | - ? ? ?|| [istarget "x86_64-*-linux*"])
> | + ? ? ?|| [istarget "i*86-*-nacl*"]
> | + ? ? ?|| [istarget "x86_64-*-nacl*"])
> | ? ? ?|| ![is_elf_format]
> | ? ? ?|| [is_remote host]} then {
> | ? ? ?return
>
> Thusly fixed:
>
> binutils/testsuite/
> ? ? ? ?* binutils-all/i386/i386.exp: Don't skip for x86_64-*-linux*.
>
> diff --git a/binutils/testsuite/binutils-all/i386/i386.exp b/binutils/testsuite/binutils-all/i386/i386.exp
> index d06501a..4b9fffd 100644
> --- a/binutils/testsuite/binutils-all/i386/i386.exp
> +++ b/binutils/testsuite/binutils-all/i386/i386.exp
> @@ -18,6 +18,7 @@
> ?if {!([istarget "i*86-*-linux*"]
> ? ? ? || [istarget "i*86-*-gnu*"]
> ? ? ? || [istarget "i*86-*-nacl*"]
> + ? ? ?|| [istarget "x86_64-*-linux*"]
> ? ? ? || [istarget "x86_64-*-nacl*"])
> ? ? || ![is_elf_format]
> ? ? || [is_remote host]} then {
>
>
> A quick pre/after testing doesn't show any further regressions on
> x86_64-linux-gnu Debian GNU/Linux.
>
It is OK.
Thanks.
--
H.J.