This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA/ARM] Fix bug with handling of BKPT and IT blocks.
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Matthew Gretton-Dann <matthew dot gretton-dann at arm dot com>
- Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 12 Jun 2012 14:06:15 +0100
- Subject: Re: [RFA/ARM] Fix bug with handling of BKPT and IT blocks.
- References: <4FCF7985.50705@arm.com>
On 06/06/12 16:38, Matthew Gretton-Dann wrote:
> All,
>
> The attached patch fixes a bug in gas with respect to its handling of BKPT
> instructions inside IT blocks.
>
> BKPT instructions are always unconditional even inside an IT block.
>
> Gas correctly handles this when an immediate is specified for the BKPT
> instruction, but does not when the immediate is omitted.
>
> OK?
>
> gas/ChangeLog:
> 2012-06-06 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * config/tc-arm.c (do_t_bkpt): Handle IT state even if there is
> no argument.
>
> gas/testsuite/ChangeLog:
> 2012-06-06 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * gas/arm/thumb2_bcond.d: Test bkpt with no arguments.
> * gas/arm/thumb2_bcond.s: Likewise.
>
OK.
R.