This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
PATCH: Simplify global symbol handling
- From: "H.J. Lu" <hongjiu dot lu at intel dot com>
- To: binutils at sourceware dot org
- Date: Fri, 29 Jun 2012 10:00:18 -0700
- Subject: PATCH: Simplify global symbol handling
- Reply-to: "H.J. Lu" <hjl dot tools at gmail dot com>
Hi,
I checked in this patch to simplify global symbol handling.
H.J.
---
diff --git a/binutils/ChangeLog b/binutils/ChangeLog
index 2448972..35f1bcb 100644
--- a/binutils/ChangeLog
+++ b/binutils/ChangeLog
@@ -1,3 +1,7 @@
+2012-06-29 H.J. Lu <hongjiu.lu@intel.com>
+
+ * nm.c (filter_symbols): Simplify global symbol handling.
+
2012-06-29 Francois Gouget <fgouget@codeweavers.com>
PR binutils/14302
diff --git a/binutils/nm.c b/binutils/nm.c
index 27019e1..ad38e27 100644
--- a/binutils/nm.c
+++ b/binutils/nm.c
@@ -435,10 +435,10 @@ filter_symbols (bfd *abfd, bfd_boolean is_dynamic, void *minisyms,
if (undefined_only)
keep = bfd_is_und_section (sym->section);
else if (external_only)
- keep = ((sym->flags & BSF_GLOBAL) != 0
- || (sym->flags & BSF_WEAK) != 0
- /* PR binutls/12753: Unique symbols are global too. */
- || (sym->flags & BSF_GNU_UNIQUE) != 0
+ /* PR binutls/12753: Unique symbols are global too. */
+ keep = ((sym->flags & (BSF_GLOBAL
+ | BSF_WEAK
+ | BSF_GNU_UNIQUE)) != 0
|| bfd_is_und_section (sym->section)
|| bfd_is_com_section (sym->section));
else