Re: Fixed: the new test ld-elf/pr14156c fails for arm-eabi

[Andrew Pinski <pinskia at gmail dot com>]

On Fri, Jul 13, 2012 at 2:45 PM, Hans-Peter Nilsson
<hans-peter.nilsson@axis.com> wrote:
> I saw for my autotester, ever since this test was added:
>
> Running /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/elf.exp ...
> FAIL: ld-elf/pr14156c
>
> and in the ld.log:
> /tmp/hpautotest-binutils/arm-unknown-eabi/ld/../gas/as-new    -o tmpdir/dump0.o /tmp/hpautotest-binutils/bsrc/src/ld/tes
> tsuite/ld-elf/foo0.s
> Executing on host: sh -c {/tmp/hpautotest-binutils/arm-unknown-eabi/ld/../gas/as-new    -o tmpdir/dump0.o /tmp/hpautotes
> t-binutils/bsrc/src/ld/testsuite/ld-elf/foo0.s 2>&1}  /dev/null ld.tmp (timeout = 300)
> /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/foo0.s: Assembler messages:
> /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/foo0.s:12: Error: junk at end of line, first unrecognized characte
> r is `,'
> /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/foo0.s: Assembler messages:
> /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/foo0.s:12: Error: junk at end of line, first unrecognized characte
> r is `,'
>
> failed with: </tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/foo0.s: Assembler messages:
> /tmp/hpautotest-binutils/bsrc/src/ld/testsuite/ld-elf/foo0.s:12: Error: junk at end of line, first unrecognized characte
> r is `,'
>>
> FAIL: ld-elf/pr14156c
>
> This was rather easily fixable, so I committed the following as
> obvious (after a sanity check for cris-elf too).  I'll suggest
> that people please use the list of targets posted somewhat
> recently as a sanity check when adding new tests, and besides,
> it's rather known that ARM has an odd .section syntax, and that
> there is a compatible syntax different from what e.g. GCC emits
> for most targets.  The only other .s files in ld-elf with the
> @-syntax are assembled just for x86_64.

It is not that ARM has an odd .section syntax but rather @ is the
comment character in ARM.

Thanks,
Andrew Pinski