This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: adjust diagnostic for bad 4-bit immediates
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: binutils at sourceware dot org
- Date: Mon, 30 Jul 2012 10:04:52 -0700
- Subject: Re: [PATCH] x86: adjust diagnostic for bad 4-bit immediates
- References: <500EDBB502000078000903BB@nat28.tlf.novell.com>
On Tue, Jul 24, 2012 at 8:30 AM, Jan Beulich <JBeulich@suse.com> wrote:
> The current error message for bad imm4 operands wasn't really helpful,
> and was pointing at the wrong operand in Intel mode. Since non-constant
> operands are being taken care of by other means anyway, adjust it to
> simply state that the constant doesn't fit.
>
> 2012-07-24 Jan Beulich <jbeulich@suse.com>
>
> * config/tc-i386-intel.c (match_template): Adjust error message
> for 'bad_imm4' case.
>
> --- a/gas/config/tc-i386.c
> +++ b/gas/config/tc-i386.c
> @@ -4347,7 +4347,7 @@ check_reverse:
> err_msg = _("invalid instruction suffix");
> break;
> case bad_imm4:
> - err_msg = _("Imm4 isn't the first operand");
> + err_msg = _("Constant doesn't fit in 4 bits");
> break;
> case old_gcc_only:
> err_msg = _("only supported with old gcc");
>
Error message starts with the lower case. OK with
that change.
--
H.J.