Re: [RFC PATCH] Fix decoding of superfluous data32 prefix before superfluous rex.W prefix before push.

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Mon, Aug 6, 2012 at 12:53 PM, Roland McGrath <mcgrathr@google.com> wrote:
> Thanks for that pointer.  I followed that hint to do a few more similar
> changes and managed to get to where all the "66 48 ..." cases in
> x86-64-stack.s produce "data32 rex.W ...".  Here's the final change
> including all that.
>
> There are no other 'make check' regressions on x86_64-linux-gnu.
> The disassembler code is so hairy that I can't be sure I haven't broken
> some other case for which there is no test coverage.  But you might
> know it enough better that you can be more confident than I am.
>
> Ok for trunk?
>
>
> Thanks,
> Roland
>
>
> gas/testsuite/
> 2012-08-06  Roland McGrath  <mcgrathr@google.com>
>
>         * gas/i386/x86-64-stack.s: Add cases for push immediate.
>         * gas/testsuite/gas/i386/ilp32/x86-64-stack-intel.d: Updated.
>         * gas/testsuite/gas/i386/ilp32/x86-64-stack-suffix.d: Updated.
>         * gas/testsuite/gas/i386/ilp32/x86-64-stack.d: Updated.
>         * gas/testsuite/gas/i386/x86-64-stack-intel.d: Updated.
>         * gas/testsuite/gas/i386/x86-64-stack-suffix.d: Updated.
>         * gas/testsuite/gas/i386/x86-64-stack.d: Updated.
>
> opcodes/
> 2012-08-06  Roland McGrath  <mcgrathr@google.com>
>             Victor Khimenko  <khim@google.com>
>             H.J. Lu  <hongjiu.lu@intel.com>
>
>         * i386-dis.c (OP_sI): In b_T_mode and v_mode, REX_W trumps DFLAG.
>         (putop): For 'T', 'U', and 'V', treat REX_W like DFLAG.
>         (intel_operand_size): For stack_v_mode, treat REX_W like DFLAG.
>         (OP_E_register): Likewise.
>         (OP_REG): For low 8 whole registers, treat REX_W like DFLAG.
>

It is OK.

Thanks.

-- 
H.J.