This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GOLD] tidy powerpc Glink_sym_ent


On Mon, Aug 13, 2012 at 7:11 AM, Alan Modra <amodra@gmail.com> wrote:
>
>         * powerpc.cc (Powerpc_relobj::set_got2_shndx): Delete.
>         (Powerpc_relobj::do_find_special_sections): Don't use set_got2_shndx.
>         (Output_data_glink::add_entry,find_entry): Remove shndx param.
>         (class Glink_sym_ent): Rename from struct Glink_sym_ent.  Remove
>         all references to shndx_.  Handle special case for R_PPC_PLTREL24
>         here.
>         (class Glink_sym_ent_hash): Rename from struct Glink_sym_ent_hash.
>         (Output_data_glink::do_write): Retrieve got2_shdnx from object.
>         (Target_powerpc::make_plt_entry): Don't special case R_PPC_PLTREL24
>         here.
>         (Target_powerpc::Scan::global): Nor on make_plt_entry call.
>         (Target_powerpc::Relocate::relocate): Nor on glink->find_entry call.

This is OK.

Thanks.

In general, please feel free to commit changes to gold/powerpc.cc
without prior review.  I would prefer to review patches to the other
files in gold, though.  Of course I'm happy to look at any patch to
powerpc.cc if you aren't sure about it.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]