This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/ARM 18/21] Add support for AES instructions.


On 23/08/12 16:04, Matthew Gretton-Dann wrote:
> 
> ARMv8 adds several AES instructions for A32 and T32.
> 
> This patch adds support for these.
> 
> gas/ChangeLog:
> 2012-08-23  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* config/tc-arm.c (NEON_ENC_TAB): Add aes entry.
> 	(neon_type_mask): Add N_UNT.
> 	(neon_check_type): Don't always decay typed to untyped sizes.
> 	(do_crypto_2op_1): New function.
> 	(do_aese): Likewise.
> 	(do_aesd): Likewise.
> 	(do_aesmc.8): Likewise.
> 	(do_aesimc.8): Likewise.
> 	(insns): Add AES instructions.
> 
> gas/testsuite/ChangeLog:
> 2012-08-23  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* gas/arm/armv8-a+crypto.d: New testcase.
> 	* gas/arm/armv8-a+crypto.s: Likewise.
> 
> opcodes/ChangeLog:
> 2012-08-23  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* arm-dis.c (neon_opcodes): Add support for AES instructions.
> 

OK, apart from:


>  /* Overall per-instruction processing.	*/

It looks like you've got a tab, rather than two spaces at the end of
this comment.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]