This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Add CX16 flag to asm

From: Michael Zolotukhin <michael dot v dot zolotukhin at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: binutils at sourceware dot org, Kirill Yukhin <kirill dot yukhin at gmail dot com>
Date: Thu, 20 Sep 2012 01:46:55 +0400
Subject: Re: [PATCH] Add CX16 flag to asm
References: <CANtU07-4YVJf2xOdwNKHiQVyp4JmA0=aBj8ignNbFxZDu1d7pw@mail.gmail.com> <CAMe9rOr5zja5zNxs9pN5REfYpF85ZzC5EY3avyFygxm6Cd2qiQ@mail.gmail.com>

Here is a patch with the tests - I didn't add new tests to arch-10.s,
as CMPXCHG16B is available only on 64 bits.

Changelogs:
gas/Changelog:
2012-09-19  Michael Zolotukhin  <michael.v.zolotukhin@intel.com>

        * config/tc-i386.c: Add CX16 flag.
        * doc/c-i386.texi: Document the new flag.

opcodes/Changelog:
2012-09-19  Michael Zolotukhin  <michael.v.zolotukhin@intel.com>

        * i386-gen.c (cpu_flag_init): Add CpuCX16 and add the flag to
        CPU_NOCONA_FLAGS, CPU_CORE_FLAGS, CPU_CORE2_FLAGS, CPU_COREI7_FLAGS,
        CPU_BDVER1_FLAGS, CPU_BDVER2_FLAGS, CPU_BTVER1_FLAGS,
        CPU_BTVER2_FLAGS.
        (cpu_flags): Add CpuCX16.
        * i386-opc.h: Add CpuCX16.
        * i386-opc.tbl: Use new flag in CMPXCHG16B.
        * i386-tbl.h: Regenerate.
        * i386-init.h: Likewise.

gas/testsuite/Changelog:
2012-09-19  Michael Zolotukhin  <michael.v.zolotukhin@intel.com>

        * gas/i386/x86-64-arch-2.s: Add test for CMPXCHG16B.
        * gas/i386/x86-64-arch-2.d: Update correspondingly.
        * gas/i386/x86-64-arch-2-bdver2.d: Likewise.
        * gas/i386/x86-64-arch-2-btver1.d: Likewise.
        * gas/i386/x86-64-arch-2-btver2.d: Likewise.
        * gas/i386/x86-64-arch-2-lzcnt.d: Likewise.
        * gas/i386/x86-64-arch-2-prefetchw.d: Likewise.
        * gas/i386/ilp32/x86-64-arch-2.d: Likewise.


On 19 September 2012 23:54, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Wed, Sep 19, 2012 at 12:23 PM, Michael Zolotukhin
> <michael.v.zolotukhin@gmail.com> wrote:
>> Hi,
>> This patch adds CX16 flag to asm to distinguish architectures,
>> supporting CMPXCHG16B instrcutions.
>> Is it ok for trunk?
>>
>> Changelog entries:
>>
>> gas/Changelog:
>> 2012-09-19  Michael Zolotukhin  <michael.v.zolotukhin@intel.com>
>>
>>         * config/tc-i386.c: Add CX16 flag.
>>         * doc/c-i386.texi: Document the new flag.
>>
>> opcodes/Changelog:
>> 2012-09-19  Michael Zolotukhin  <michael.v.zolotukhin@intel.com>
>>
>>         * i386-gen.c (cpu_flag_init): Add CpuCX16 and add the flag to
>>         CPU_NOCONA_FLAGS, CPU_CORE_FLAGS, CPU_CORE2_FLAGS, CPU_COREI7_FLAGS,
>>         CPU_BDVER1_FLAGS, CPU_BDVER2_FLAGS, CPU_BTVER1_FLAGS,
>>         CPU_BTVER2_FLAGS.
>>         (cpu_flags): Add CpuCX16.
>>         * i386-opc.h: Add CpuCX16.
>>         * i386-opc.tbl: Use new flag in CMPXCHG16B.
>>         * i386-tbl.h: Regenerate.
>>         * i386-init.h: Likewise.
>>
>
> Please add a cx16 test to gas/i386/arch-10.s and gas/i386/x86-64-arch-2.s
>
> Thanks.
>
>
> --
> H.J.



-- 
---
Best regards,
Michael V. Zolotukhin,
Software Engineer
Intel Corporation.

Attachment: cx16-2.patch.tar.gz
Description: GNU Zip compressed data

Follow-Ups:
- Re: [PATCH] Add CX16 flag to asm
  - From: H.J. Lu
- Re: [PATCH] Add CX16 flag to asm
  - From: H.J. Lu

References:
- [PATCH] Add CX16 flag to asm
  - From: Michael Zolotukhin
- Re: [PATCH] Add CX16 flag to asm
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]