Re: [PATCH 05/12] libiberty/ * configure: Add Microblaze PICFLAG

[Andrew Pinski <pinskia at gmail dot com>]

On Wed, Oct 10, 2012 at 8:42 AM, Ralf Corsepius
<ralf.corsepius@rtems.org> wrote:
> On 10/10/2012 04:13 AM, david.holsgrove@xilinx.com wrote:
>>
>> From: David Holsgrove <david.holsgrove@xilinx.com>
>>
>> Microblaze requires libiberty to be compiled with -fPIC
>
> Why? Which target platforms are you actually building for?
>
>> diff --git a/libiberty/configure b/libiberty/configure
>> index 6e98352..266d8b2 100755
>> --- a/libiberty/configure
>> +++ b/libiberty/configure
>> @@ -4899,6 +4899,9 @@ case "${host}" in
>>       m68k-*-*)
>>         PICFLAG=-fpic
>>         ;;
>> +    microblaze*-*-*)
>> +       PICFLAG=-fPIC
>> +       ;;
>
>
> So far, we have been building binutils for microblaze-rtems*
>  without -fPIC.
>
> I am inclined to believe you are generalizing too far on a certain OS's
> specific demands/restrictions.

I think he means to build it on microblaze-linux-gnu itself; not as
part of a cross toolchain.

Thanks,
Andrew Pinski