This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 04/12] bfd/ * bfd/elf32-microblaze.c: Correct adjustment of global symbols

From: David Holsgrove <david dot holsgrove at xilinx dot com>
To: Michael Eager <eager at eagercon dot com>
Cc: Mike Frysinger <vapier at gentoo dot org>, binutils at sourceware dot org, edgar dot iglesias at gmail dot com, john dot williams at xilinx dot com, Vidhumouli Hunsigida <vidhumouli dot hunsigida at xilinx dot com>, Nagaraju Mekala <nagaraju dot mekala at xilinx dot com>
Date: Thu, 11 Oct 2012 15:57:53 +1000
Subject: Re: [PATCH 04/12] bfd/ * bfd/elf32-microblaze.c: Correct adjustment of global symbols
References: <cover.1349834840.git.david.holsgrove@xilinx.com> <99f57522696cdcb8a299fa72203f307f826f58e4.1349834840.git.david.holsgrove@xilinx.com> <201210101405.26719.vapier@gentoo.org> <5075BE75.4090207@eagercon.com>

Hi Mike, Michael, All

On 11 October 2012 04:29, Michael Eager <eager@eagercon.com> wrote:
> On 10/10/2012 11:05 AM, Mike Frysinger wrote:
>>
>> On Tuesday 09 October 2012 22:13:57 david.holsgrove@xilinx.com wrote:
>>>
[SNIP]
> Bfd has very little debugging code, but there is an example in bfdwin.c.
> This
> uses a global symbol which can be set by a debugger to enable debug output.
> A
> better method is to enable this by a command line option, but this may not
> be
> as practical for bfd, which is used by several components.
>
> If the debug code is really necessary, it should not require someone
> to modify the file to enable it.
>
> I think that this is development code and is not needed.
>

Yes, this is primarily debug information left over from development,
and I would prefer to remove it from the patch.
I'll update this in the resubmitted patch series.

> --
> Michael Eager    eager@eagercon.com
> 1960 Park Blvd., Palo Alto, CA 94306  650-325-8077
>
>

regards,
David

References:
- [PATCH 00/12] Xilinx MicroBlaze Support Update
  - From: david . holsgrove
- [PATCH 04/12] bfd/ * bfd/elf32-microblaze.c: Correct adjustment of global symbols
  - From: david . holsgrove
- Re: [PATCH 04/12] bfd/ * bfd/elf32-microblaze.c: Correct adjustment of global symbols
  - From: Mike Frysinger
- Re: [PATCH 04/12] bfd/ * bfd/elf32-microblaze.c: Correct adjustment of global symbols
  - From: Michael Eager

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]