Re: [PATCH][AARCH64] Fix TLS relocation resolution

[Yufeng Zhang <Yufeng dot Zhang at arm dot com>]

On 10/16/12 17:02, Richard Earnshaw wrote:
> On 16/10/12 16:46, Marcus Shawcroft wrote:
> > On 16/10/12 16:14, Sofiane Naci wrote:
> > > Hi,
> > >
> > > This patch fixes a bug in the resolution of AArch64 TLS relocations
> > > AARCH64_TLSLE_*_TPREL_*.
> > > It also fixes wrong shift values for some of the AArch64 TLS relocations in
> > > the howto tables.
> >
> > The change to shift values and signed_addend look correct to me.  The
> > test added covers R_AARCH64_TLSLE_ADD_TPREL_HI12 and
> > R_AARCH64_TLSLE_ADD_TPREL_LO12 but is missing coverage of the other
> > relocations modified by the patch.
> >
> > This addresses a rather nasty issue in the toolchain, have we missed 2.23 ?
>
> This is OK for trunk and, if/when Tristan agrees for the 2.23 branch.

Committed the patch to the trunk for Sofiane.

Here is the url of the commit mail:
http://sourceware.org/ml/binutils-cvs/2012-10/msg00065.html


Thanks,
Yufeng