[gold] Build regression on i386 host [Re: [patch 6/7] [gold] Add initial source code for dwp utility.]

[Jan Kratochvil <jan dot kratochvil at redhat dot com>]

Hello Cary,

Fedora 18 i386 (x86_64 is OK):

./configure --enable-gold; make

On Sat, 20 Oct 2012 00:12:28 +0200, Cary Coutant wrote:
> +unsigned int
> +Dwo_file::remap_str_offset(unsigned int val)
> +{
> +  Str_offset_map_entry entry;
> +  entry.first = val;
> +
> +  Str_offset_map::const_iterator p =
> +      std::lower_bound(this->str_offset_map_.begin(),
> +		       this->str_offset_map_.end(),
> +		       entry, Offset_compare());
> +
> +  if (p == this->str_offset_map_.end() || p->first > val)

dwp.cc:1334:54: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

> +    {
> +      if (p == this->str_offset_map_.begin())
> +	return 0;
> +      --p;
> +      gold_assert(p->first <= val);

dwp.cc:1339:7: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]

> +    }
> +
> +  return p->second + (val - p->first);
> +}


Thanks,
Jan