This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: top-level configure.ac changes lost in sync


On Wed, Nov 14, 2012 at 4:13 PM, Roland McGrath <mcgrathr@google.com> wrote:
> I've just noticed that this change (git mirror view):
>
>         commit 7228bb7b806e7f0513557e3002a6dca104a768a1
>         Author: H.J. Lu <hjl.tools@gmail.com>
>         Date:   Sun Aug 26 14:34:38 2012 +0000
>
>             Sync toplevel files with GCC tree
>
> silently reverted my earlier change:
>
>         2012-05-02  Roland McGrath  <mcgrathr@google.com>
>
>                 * configure.ac (ENABLE_GOLD): Consider *-*-nacl* targets ELF.
>                 * configure: Regenerate.

It was an oversight.  Sorry for that.

> Since my change was approved here and nobody told me otherwise, I did not
> expect that the change had to be made somewhere else to avoid being
> silently clobbered by a blind copying of files from elsewhere.  If verbatim
> copying without regard to divergence is the policy, there should be some
> loud comments at the top of configure.ac and other such files, IMHO.
>
> The patch below restores the wrongly-reverted change.  How do I get this
> in so it won't be clobbered again?
>

You should apply toplevel file changes to GCC and src trees at the same time.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]