This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Scan for Mach-O start address in LC_MAIN and properly check bfd_mach_o_scan_start_address's return value


On Thu, Nov 22, 2012 at 12:33 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> I'm not sure how involved I'm going to be, so go ahead and rewrite it.
>> The next time I submit some code, I will do the paperwork.
>
> I recommend you do the paperwork now, because it does take a few weeks
> to complete.

Ok, I'm happy to start this now. Someone (Nick?) let me know what I need to do.

>
>> One question: do you know if there are going to be any more GDB 7.5.x
>> releases or will the next release be 7.6? It would be nice if this
>> change and your changes supporting the new load commands could be in
>> the next version of GDB, whatever that ends up being. If there's going
>> to be a 7.5.1, I'm happy to backport the changes to the 7.5 branch.
>> I'll probably be making a patch to 7.5 for the homebrew
>> (mxcl.github.com/homebrew) formula anyway.
>
> I just sent an email earlier today, actually, suggesting that
> we make a 7.5.1 release around Wed next week. It's getting really
> tight for getting this in that release, unless it's critical.
>
> You'll need to characterize what the user-visible problems are
> that your patch is solving. If deemed critical and assessed as
> completely safe, we can hold the release for a few more days.

It would be nice to see Tristan's changes to BFD from November 14th
make it into 7.5.1. Without them you get a whole bunch of errors every
time you run GDB (https://gist.github.com/4137073). You can continue
working after that, but it's ugly and gives the impression that GDB is
somehow broken. There are also some functional changes regarding how
these new load commands are handled, but I don't know how they affect
GDB.

I don't know enough about GDB yet to know what user-visible problems
my patch fixes. Without it, abfd->start_address can be NULL when it
shouldn't be for binaries compiled on OS X 10.8 (possibly 10.7 too,
but I don't have an install to check).

Best,
-David

>
> --
> Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]