This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Recognize the armv7 pe magic


On 29/11/12 14:47, Martin Storsjo wrote:
---
  include/coff/arm.h |    3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

---
Updated the patch to rename it to ARMV7PEMAGIC, which is more consistent
with the existing defines.



This is OK, though I will note here that I think it is generally a bad idea to try and encode the architecture variant in the magic number -- it's just too simplistic.


R.




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]