This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GOLD] PowerPC64 toc code optimization

On Thu, Dec 06, 2012 at 03:48:45PM -0800, Ian Lance Taylor wrote:
> On Thu, Dec 6, 2012 at 5:20 AM, Alan Modra <amodra@gmail.com> wrote:
> >
> >         * options.h (General_options): Add no_toc_optimize.
> >         * powerpc.cc (ok_lo_toc_insn): New function.
> >         (Target_powerpc::Relocate::relocate): Optimize toc access sequences.
> 
> This is OK.
> 
> Thanks.
> 
> Doug's suggestion does seem reasonable.

I committed it as is for the reason (excuse!) given in my other email.
I don't feel too strongly about the style one way or another; I'd agree
wholeheartedly with Doug if all the insn matching was just on the top
6 bits.  If you or Doug want to change this code, or anything else in
powerpc.cc please go ahead.

-- 
Alan Modra
Australia Development Lab, IBM
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]