Re: Map ".text.hot" and ".text.unlikely" input section prefixes to separate output sections.

[Sriraman Tallam <tmsriram at google dot com>]

On Wed, Dec 19, 2012 at 11:51 AM, Ian Lance Taylor <iant@google.com> wrote:
> On Tue, Dec 18, 2012 at 6:57 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>> On Tue, Dec 18, 2012 at 5:39 PM, Ian Lance Taylor <iant@google.com> wrote:
>>> On Tue, Nov 20, 2012 at 7:08 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>>>
>>>>       * layout.cc (Layout::is_section_name_prefix_grouped): New function.
>>>>       * layout.h (Layout::is_section_name_prefix_grouped): New function.
>>>>       * output.cc (Output_section::add_input_section): Check if section
>>>>       name contains special prefix.  Keep input sections to sort such
>>>>       sections.
>>>>       (Output_section::Input_section_sort_section_order_index_compare
>>>>        ::operator()): Group sections according to prefixes.
>>>>       * (Output_section::sort_attached_input_sections): Add condition
>>>>       to Input_section_entry constructor call.
>>>>       * testsuite/Makefile.am (text_section_grouping): New test.
>>>>       * testsuite/Makefile.in: Regenerate.
>>>>       * testsuite/text_section_grouping.cc: New file.
>>>>       * testsuite/text_section_grouping.sh: New file.
>>>
>>>
>>>> +  // If it is a text section use the following order:
>>>> +  // .text.unlikely, .text.startup, .text.hot.
>>>> +  const char* section_prefix [] =
>>>> +  {
>>>> +    ".text.unlikely",
>>>> +    ".text.startup",
>>>> +    ".text.hot"
>>>> +  };
>>>
>>> Please mention in the comment that this should match
>>> Layout::is_section_name_prefix_grouped.
>>>
>>> This is OK with that change.
>>
>> Made the change and committed the patch.
>
> I'm seeing a number of testsuite failures that I don't see when I
> revert your patch.  In fact the linker doesn't seem to work properly
> at all, in that the bootstrap test fails.  Could you look into that?
> Thanks.

I will take a look now. Surprisingly, no tests fail for me.

-Sri.


>
> Ian
>
> make  libgoldtest.a object_unittest binary_unittest leb128_unittest
> icf_virtual_function_folding_test basic_test basic_pic_test
> basic_static_test basic_static_pic_test basic_pie_test
> constructor_test constructor_static_test two_file_test
> two_file_pic_test two_file_static_test two_file_shared_1_test
> two_file_shared_2_test two_file_shared_1_pic_2_test
> two_file_shared_2_pic_1_test two_file_same_shared_test
> two_file_separate_shared_12_test two_file_separate_shared_21_test
> two_file_relocatable_test two_file_pie_test  two_file_strip_test
> two_file_same_shared_strip_test common_test_1 common_test_2
> exception_test exception_shared_1_test exception_shared_2_test
> exception_same_shared_test exception_separate_shared_12_test
> exception_separate_shared_21_test exception_static_test weak_test
> weak_undef_test  weak_alias_test weak_plt copy_test tls_test
> tls_pic_test tls_pie_test tls_pie_pic_test tls_shared_test
> tls_shared_ie_test tls_shared_gd_to_ie_test
> tls_shared_gnu2_gd_to_ie_test tls_shared_gnu2_test tls_static_test
> tls_static_pic_test  many_sections_test many_sections_r_test initpri1
> initpri2 initpri3a flagstest_o_specialfile
> flagstest_compress_debug_sections
> flagstest_o_specialfile_and_compress_debug_sections
> flagstest_o_ttext_1 ver_test ver_test_2 ver_test_6 ver_test_8
> ver_test_9 ver_test_11 ver_test_12 protected_1 protected_2 relro_test
> relro_now_test relro_strip_test relro_script_test script_test_1
> script_test_2 justsyms justsyms_exec binary_test script_test_3
> tls_phdrs_script_test tls_script_test thin_archive_test_1
> thin_archive_test_2 plugin_test_1 plugin_test_2 plugin_test_3
> plugin_test_4 plugin_test_5 plugin_test_6 plugin_test_7 plugin_test_8
> exclude_libs_test local_labels_test discard_locals_test large
> permission_test searched_file_test ifuncmain1static
> ifuncmain1picstatic ifuncmain1 ifuncmain1pic ifuncmain1vis
> ifuncmain1vispic ifuncmain1staticpic ifuncmain1pie ifuncmain1vispie
> ifuncmain1staticpie ifuncmain2static ifuncmain2picstatic ifuncmain2
> ifuncmain2pic ifuncmain3 ifuncmain4static ifuncmain4picstatic
> ifuncmain4 ifuncmain5static ifuncmain5picstatic ifuncmain5
> ifuncmain5pic ifuncmain5staticpic ifuncmain5pie ifuncmain6pie
> ifuncmain7static ifuncmain7picstatic ifuncmain7 ifuncmain7pic
> ifuncmain7pie ifuncvar start_lib_test incremental_test_2
> incremental_test_3 incremental_test_4 incremental_test_5
> incremental_test_6 incremental_copy_test incremental_common_test_1
> incremental_comdat_test_1 \
>           incremental_test.sh gc_comdat_test.sh gc_tls_test.sh
> gc_orphan_section_test.sh pr14265.sh icf_test.sh
> icf_keep_unique_test.sh icf_safe_test.sh icf_safe_so_test.sh
> final_layout.sh text_section_grouping.sh
> icf_preemptible_functions_test.sh icf_string_merge_test.sh
> icf_sht_rel_addend_test.sh two_file_shared.sh weak_plt.sh debug_msg.sh
> undef_symbol.sh ver_test_1.sh ver_test_2.sh ver_test_4.sh
> ver_test_5.sh ver_test_7.sh ver_test_10.sh relro_test.sh
> ver_matching_test.sh script_test_3.sh script_test_4.sh
> script_test_5.sh script_test_6.sh script_test_7.sh script_test_8.sh
> script_test_9.sh dynamic_list.sh plugin_test_1.sh plugin_test_2.sh
> plugin_test_3.sh plugin_test_4.sh plugin_test_6.sh plugin_test_7.sh
> plugin_final_layout.sh exclude_libs_test.sh discard_locals_test.sh
> hidden_test.sh retain_symbols_file_test.sh no_version_test.sh
> strong_ref_weak_def.sh dyn_weak_ref.sh memory_test.sh
> script_test_10.sh  split_x86_64.sh  dwp_test_1.sh dwp_test_2.sh
> incremental_test.stdout gc_comdat_test.stdout gc_tls_test.stdout
> gc_orphan_section_test.stdout pr14265.stdout icf_test.stdout
> icf_keep_unique_test.stdout icf_safe_test_1.stdout
> icf_safe_test_2.stdout icf_safe_so_test_1.stdout
> icf_safe_so_test_2.stdout final_layout.stdout
> text_section_grouping.stdout icf_preemptible_functions_test.stdout
> icf_string_merge_test.stdout icf_sht_rel_addend_test.stdout
> two_file_shared.dbg weak_plt_shared.so debug_msg.err
> debug_msg_cdebug.err debug_msg_so.err debug_msg_ndebug.err
> undef_symbol.err flagstest_o_ttext_2 ver_test_1.syms ver_test_2.syms
> ver_test_4.syms ver_test_5.syms ver_test_7.syms ver_test_10.syms
> protected_3.err relro_test.stdout ver_matching_test.stdout
> script_test_3.stdout script_test_4.stdout script_test_5.stdout
> script_test_6.stdout script_test_7.stdout script_test_8.stdout
> script_test_9.stdout dynamic_list.stdout plugin_test_1.err
> plugin_test_2.err plugin_test_3.err plugin_test_4.err
> plugin_test_6.err plugin_test_7.err plugin_test_7.syms
> plugin_test_9.err plugin_final_layout.stdout
> plugin_final_layout_readelf.stdout exclude_libs_test.syms
> discard_locals_test.syms discard_locals_relocatable_test1.syms
> discard_locals_relocatable_test2.syms hidden_test.err
> retain_symbols_file_test.stdout no_version_test.stdout
> strong_ref_weak_def.stdout dyn_weak_ref.stdout memory_test.stdout
> script_test_10.stdout  split_x86_64_1.stdout split_x86_64_2.stdout
> split_x86_64_3.stdout split_x86_64_4.stdout split_x86_64_r.stdout
> dwp_test_1.stdout dwp_test_2.stdout
> make[4]: Entering directory
> `/usr/local/google/iant/gold/gold-objdir/gold/testsuite'
> make[4]: `libgoldtest.a' is up to date.
> make[4]: `object_unittest' is up to date.
> make[4]: `binary_unittest' is up to date.
> make[4]: `leb128_unittest' is up to date.
> make[4]: `icf_virtual_function_folding_test' is up to date.
> make[4]: `basic_test' is up to date.
> make[4]: `basic_pic_test' is up to date.
> make[4]: `basic_static_test' is up to date.
> make[4]: `basic_static_pic_test' is up to date.
> make[4]: `basic_pie_test' is up to date.
> make[4]: `constructor_test' is up to date.
> make[4]: `constructor_static_test' is up to date.
> make[4]: `two_file_test' is up to date.
> make[4]: `two_file_pic_test' is up to date.
> make[4]: `two_file_static_test' is up to date.
> make[4]: `two_file_shared_1_test' is up to date.
> make[4]: `two_file_shared_2_test' is up to date.
> make[4]: `two_file_shared_1_pic_2_test' is up to date.
> make[4]: `two_file_shared_2_pic_1_test' is up to date.
> make[4]: `two_file_same_shared_test' is up to date.
> make[4]: `two_file_separate_shared_12_test' is up to date.
> make[4]: `two_file_separate_shared_21_test' is up to date.
> make[4]: `two_file_relocatable_test' is up to date.
> make[4]: `two_file_pie_test' is up to date.
> make[4]: `two_file_strip_test' is up to date.
> make[4]: `two_file_same_shared_strip_test' is up to date.
> make[4]: `common_test_1' is up to date.
> make[4]: `common_test_2' is up to date.
> make[4]: `exception_test' is up to date.
> make[4]: `exception_shared_1_test' is up to date.
> make[4]: `exception_shared_2_test' is up to date.
> make[4]: `exception_same_shared_test' is up to date.
> make[4]: `exception_separate_shared_12_test' is up to date.
> make[4]: `exception_separate_shared_21_test' is up to date.
> make[4]: `exception_static_test' is up to date.
> make[4]: `weak_test' is up to date.
> make[4]: `weak_undef_test' is up to date.
> make[4]: `weak_alias_test' is up to date.
> make[4]: `weak_plt' is up to date.
> make[4]: `copy_test' is up to date.
> g++ -W -Wall    -Werror -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> -fmerge-constants -g -O2 -Bgcctestdir/  -o tls_test tls_test.o
> tls_test_file2.o tls_test_main.o tls_test_c.o -lpthread -lz
> gcctestdir/ld: internal error in write_sections, at ../../src/gold/reloc.cc:830
> collect2: ld returned 1 exit status
> make[4]: *** [tls_test] Error 1
> make[4]: `tls_pic_test' is up to date.
> make[4]: `tls_pie_test' is up to date.
> make[4]: `tls_pie_pic_test' is up to date.
> make[4]: `tls_shared_test' is up to date.
> make[4]: `tls_shared_ie_test' is up to date.
> make[4]: `tls_shared_gd_to_ie_test' is up to date.
> make[4]: `tls_shared_gnu2_gd_to_ie_test' is up to date.
> make[4]: `tls_shared_gnu2_test' is up to date.
> make[4]: `tls_static_test' is up to date.
> make[4]: `tls_static_pic_test' is up to date.
> make[4]: `many_sections_test' is up to date.
> make[4]: `many_sections_r_test' is up to date.
> make[4]: `initpri1' is up to date.
> gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror
> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fmerge-constants -g -O2
> -Bgcctestdir/ -Wl,--ctors-in-init-array  -o initpri2 initpri2.o  -lz
> gcctestdir/ld: internal error in write_sections, at ../../src/gold/reloc.cc:830
> collect2: ld returned 1 exit status
> make[4]: *** [initpri2] Error 1
> make[4]: `initpri3a' is up to date.
> make[4]: `flagstest_o_specialfile' is up to date.
> make[4]: `flagstest_compress_debug_sections' is up to date.
> make[4]: `flagstest_o_specialfile_and_compress_debug_sections' is up to date.
> make[4]: `flagstest_o_ttext_1' is up to date.
> make[4]: `ver_test' is up to date.
> make[4]: `ver_test_2' is up to date.
> make[4]: `ver_test_6' is up to date.
> make[4]: `ver_test_8' is up to date.
> make[4]: `ver_test_9' is up to date.
> make[4]: `ver_test_11' is up to date.
> make[4]: `ver_test_12' is up to date.
> make[4]: `protected_1' is up to date.
> make[4]: `protected_2' is up to date.
> make[4]: `relro_test' is up to date.
> make[4]: `relro_now_test' is up to date.
> make[4]: `relro_strip_test' is up to date.
> make[4]: `relro_script_test' is up to date.
> make[4]: `script_test_1' is up to date.
> make[4]: `script_test_2' is up to date.
> make[4]: `justsyms' is up to date.
> make[4]: `justsyms_exec' is up to date.
> make[4]: `binary_test' is up to date.
> make[4]: `script_test_3' is up to date.
> make[4]: `tls_phdrs_script_test' is up to date.
> make[4]: `tls_script_test' is up to date.
> make[4]: `thin_archive_test_1' is up to date.
> make[4]: `thin_archive_test_2' is up to date.
> make[4]: `plugin_test_1' is up to date.
> make[4]: `plugin_test_2' is up to date.
> make[4]: `plugin_test_3' is up to date.
> make[4]: `plugin_test_4' is up to date.
> make[4]: `plugin_test_5' is up to date.
> make[4]: `plugin_test_6' is up to date.
> make[4]: `plugin_test_7' is up to date.
> make[4]: `plugin_test_8' is up to date.
> make[4]: `exclude_libs_test' is up to date.
> make[4]: `local_labels_test' is up to date.
> make[4]: `discard_locals_test' is up to date.
> make[4]: `large' is up to date.
> make[4]: `permission_test' is up to date.
> make[4]: `searched_file_test' is up to date.
> make[4]: `ifuncmain1static' is up to date.
> make[4]: `ifuncmain1picstatic' is up to date.
> make[4]: `ifuncmain1' is up to date.
> make[4]: `ifuncmain1pic' is up to date.
> make[4]: `ifuncmain1vis' is up to date.
> make[4]: `ifuncmain1vispic' is up to date.
> make[4]: `ifuncmain1staticpic' is up to date.
> make[4]: `ifuncmain1pie' is up to date.
> make[4]: `ifuncmain1vispie' is up to date.
> make[4]: `ifuncmain1staticpie' is up to date.
> make[4]: `ifuncmain2static' is up to date.
> make[4]: `ifuncmain2picstatic' is up to date.
> make[4]: `ifuncmain2' is up to date.
> make[4]: `ifuncmain2pic' is up to date.
> make[4]: `ifuncmain3' is up to date.
> make[4]: `ifuncmain4static' is up to date.
> make[4]: `ifuncmain4picstatic' is up to date.
> gcc -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Werror
> -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -fmerge-constants -g -O2
> -Bgcctestdir/  -o ifuncmain4 ifuncmain4.o  -lz
> gcctestdir/ld: internal error in write_sections, at ../../src/gold/reloc.cc:830
> collect2: ld returned 1 exit status
> make[4]: *** [ifuncmain4] Error 1
> make[4]: `ifuncmain5static' is up to date.
> make[4]: `ifuncmain5picstatic' is up to date.
> make[4]: `ifuncmain5' is up to date.
> make[4]: `ifuncmain5pic' is up to date.
> make[4]: `ifuncmain5staticpic' is up to date.
> make[4]: `ifuncmain5pie' is up to date.
> make[4]: `ifuncmain6pie' is up to date.
> make[4]: `ifuncmain7static' is up to date.
> make[4]: `ifuncmain7picstatic' is up to date.
> make[4]: `ifuncmain7' is up to date.
> make[4]: `ifuncmain7pic' is up to date.
> make[4]: `ifuncmain7pie' is up to date.
> make[4]: `ifuncvar' is up to date.
> make[4]: `start_lib_test' is up to date.
> make[4]: `incremental_test_2' is up to date.
> make[4]: `incremental_test_3' is up to date.
> make[4]: `incremental_test_4' is up to date.
> make[4]: `incremental_test_5' is up to date.
> make[4]: `incremental_test_6' is up to date.
> make[4]: `incremental_copy_test' is up to date.
> make[4]: `incremental_common_test_1' is up to date.
> make[4]: `incremental_comdat_test_1' is up to date.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/incremental_test.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/gc_comdat_test.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/gc_tls_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/gc_orphan_section_test.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/pr14265.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/icf_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/icf_keep_unique_test.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/icf_safe_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/icf_safe_so_test.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/final_layout.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/text_section_grouping.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/icf_preemptible_functions_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/icf_string_merge_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/icf_sht_rel_addend_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/two_file_shared.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/weak_plt.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/debug_msg.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/undef_symbol.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/ver_test_1.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/ver_test_2.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/ver_test_4.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/ver_test_5.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/ver_test_7.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/ver_test_10.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/relro_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/ver_matching_test.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/script_test_3.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/script_test_4.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/script_test_5.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/script_test_6.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/script_test_7.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/script_test_8.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/script_test_9.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/dynamic_list.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/plugin_test_1.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/plugin_test_2.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/plugin_test_3.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/plugin_test_4.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/plugin_test_6.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/plugin_test_7.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/plugin_final_layout.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/exclude_libs_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/discard_locals_test.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/hidden_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/retain_symbols_file_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/no_version_test.sh'.
> make[4]: Nothing to be done for
> `../../../src/gold/testsuite/strong_ref_weak_def.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/dyn_weak_ref.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/memory_test.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/script_test_10.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/split_x86_64.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/dwp_test_1.sh'.
> make[4]: Nothing to be done for `../../../src/gold/testsuite/dwp_test_2.sh'.
> make[4]: `incremental_test.stdout' is up to date.
> make[4]: `gc_comdat_test.stdout' is up to date.
> make[4]: `gc_tls_test.stdout' is up to date.
> make[4]: `gc_orphan_section_test.stdout' is up to date.
> make[4]: `pr14265.stdout' is up to date.
> make[4]: `icf_test.stdout' is up to date.
> make[4]: `icf_keep_unique_test.stdout' is up to date.
> make[4]: `icf_safe_test_1.stdout' is up to date.
> make[4]: `icf_safe_test_2.stdout' is up to date.
> make[4]: `icf_safe_so_test_1.stdout' is up to date.
> make[4]: `icf_safe_so_test_2.stdout' is up to date.
> make[4]: `final_layout.stdout' is up to date.
> make[4]: `text_section_grouping.stdout' is up to date.
> make[4]: `icf_preemptible_functions_test.stdout' is up to date.
> make[4]: `icf_string_merge_test.stdout' is up to date.
> make[4]: `icf_sht_rel_addend_test.stdout' is up to date.
> make[4]: `two_file_shared.dbg' is up to date.
> make[4]: `weak_plt_shared.so' is up to date.
> make[4]: `debug_msg.err' is up to date.
> make[4]: `debug_msg_cdebug.err' is up to date.
> make[4]: `debug_msg_so.err' is up to date.
> make[4]: `debug_msg_ndebug.err' is up to date.
> make[4]: `undef_symbol.err' is up to date.
> make[4]: `flagstest_o_ttext_2' is up to date.
> make[4]: `ver_test_1.syms' is up to date.
> make[4]: `ver_test_2.syms' is up to date.
> make[4]: `ver_test_4.syms' is up to date.
> make[4]: `ver_test_5.syms' is up to date.
> make[4]: `ver_test_7.syms' is up to date.
> make[4]: `ver_test_10.syms' is up to date.
> make[4]: `protected_3.err' is up to date.
> make[4]: `relro_test.stdout' is up to date.
> make[4]: `ver_matching_test.stdout' is up to date.
> make[4]: `script_test_3.stdout' is up to date.
> make[4]: `script_test_4.stdout' is up to date.
> make[4]: `script_test_5.stdout' is up to date.
> make[4]: `script_test_6.stdout' is up to date.
> make[4]: `script_test_7.stdout' is up to date.
> make[4]: `script_test_8.stdout' is up to date.
> make[4]: `script_test_9.stdout' is up to date.
> make[4]: `dynamic_list.stdout' is up to date.
> make[4]: `plugin_test_1.err' is up to date.
> make[4]: `plugin_test_2.err' is up to date.
> make[4]: `plugin_test_3.err' is up to date.
> make[4]: `plugin_test_4.err' is up to date.
> make[4]: `plugin_test_6.err' is up to date.
> make[4]: Nothing to be done for `plugin_test_7.err'.
> make[4]: `plugin_test_7.syms' is up to date.
> make[4]: `plugin_test_9.err' is up to date.
> make[4]: `plugin_final_layout.stdout' is up to date.
> make[4]: `plugin_final_layout_readelf.stdout' is up to date.
> make[4]: `exclude_libs_test.syms' is up to date.
> make[4]: `discard_locals_test.syms' is up to date.
> make[4]: `discard_locals_relocatable_test1.syms' is up to date.
> make[4]: `discard_locals_relocatable_test2.syms' is up to date.
> make[4]: `hidden_test.err' is up to date.
> make[4]: `retain_symbols_file_test.stdout' is up to date.
> make[4]: `no_version_test.stdout' is up to date.
> make[4]: `strong_ref_weak_def.stdout' is up to date.
> make[4]: `dyn_weak_ref.stdout' is up to date.
> make[4]: `memory_test.stdout' is up to date.
> make[4]: `script_test_10.stdout' is up to date.
> make[4]: `split_x86_64_1.stdout' is up to date.
> make[4]: `split_x86_64_2.stdout' is up to date.
> make[4]: `split_x86_64_3.stdout' is up to date.
> make[4]: `split_x86_64_4.stdout' is up to date.
> make[4]: `split_x86_64_r.stdout' is up to date.
> make[4]: `dwp_test_1.stdout' is up to date.
> make[4]: `dwp_test_2.stdout' is up to date.
> make[4]: Leaving directory
> `/usr/local/google/iant/gold/gold-objdir/gold/testsuite'
> make[3]: *** [check-am] Error 2
> make[3]: Leaving directory
> `/usr/local/google/iant/gold/gold-objdir/gold/testsuite'
> make[2]: *** [check] Error 2
> make[2]: Leaving directory
> `/usr/local/google/iant/gold/gold-objdir/gold/testsuite'
> make[2]: Entering directory `/usr/local/google/iant/gold/gold-objdir/gold'
> make  ld1 ld2 ld1-r ld2-r
> make[3]: Entering directory `/usr/local/google/iant/gold/gold-objdir/gold'
> g++ -W -Wall    -Werror -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
> -frandom-seed=ld2 -g -O2 -Bgcctestdir2/  -o ld2 main.o i386.o x86_64.o
> sparc.o powerpc.o arm.o arm-reloc-property.o tilegx.o libgold.a
> ../libiberty/libiberty.a    -ldl -lz
> (null): internal error in options, at ../../src/gold/parameters.h:92
> collect2: ld returned 1 exit status
> make[3]: *** [ld2] Error 1
> make[3]: `ld1-r' is up to date.
> gcctestdir2-r/ld -o libgold-2-r.o -r --whole-archive libgold.a
> (null): internal error in ~Task_list, at ../../src/gold/token.h:44
> make[3]: *** [libgold-2-r.o] Error 1
> make[3]: Target `ld2-r' not remade because of errors.
> make[3]: Leaving directory `/usr/local/google/iant/gold/gold-objdir/gold'
> make[2]: *** [check-am] Error 2
> make[2]: Leaving directory `/usr/local/google/iant/gold/gold-objdir/gold'
> make[1]: *** [check-recursive] Error 1
> make[1]: Target `check' not remade because of errors.
> make[1]: Leaving directory `/usr/local/google/iant/gold/gold-objdir/gold'
> make: *** [check-gold] Error 2