This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch, gas] Change 'internal Error' to 'internal error'
- From: Alan Modra <amodra at gmail dot com>
- To: Steve Ellcey <sellcey at mips dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 9 Jan 2013 13:44:26 +1030
- Subject: Re: [patch, gas] Change 'internal Error' to 'internal error'
- References: <bd988080-c109-4bfe-bcfc-6c394b022cf2@EXCHHUB01.MIPS.com>
On Tue, Jan 08, 2013 at 03:06:23PM -0800, Steve Ellcey wrote:
> I see 'internal Error' in various po/* localization files too, should I be
> regenerating those somehow?
No, that is done by the translation project.
> --- a/gas/config/tc-i386.c
> +++ b/gas/config/tc-i386.c
> @@ -2375,7 +2375,7 @@ md_begin (void)
> (void *) core_optab);
> if (hash_err)
> {
> - as_fatal (_("internal Error: Can't hash %s: %s"),
> + as_fatal (_("internal error: Can't hash %s: %s"),
> (optab - 1)->name,
> hash_err);
> }
> @@ -2397,7 +2397,7 @@ md_begin (void)
> {
> hash_err = hash_insert (reg_hash, regtab->reg_name, (void *) regtab);
> if (hash_err)
> - as_fatal (_("internal Error: Can't hash %s: %s"),
> + as_fatal (_("internal error: Can't hash %s: %s"),
> regtab->reg_name,
> hash_err);
> }
Since as_fatal prints "Fatal error: " before its argument, I'd be
inclined to make these both as_fatal (_("can't hash %s: %s"), ...
OK with that change.
> --- a/gas/config/tc-mips.c
> +++ b/gas/config/tc-mips.c
> @@ -1311,7 +1311,7 @@ static struct {
> /* Prototypes for static functions. */
>
> #define internalError() \
> - as_fatal (_("internal Error, line %d, %s"), __LINE__, __FILE__)
> + as_fatal (_("internal error, line %d, %s"), __LINE__, __FILE__)
>
> enum mips_regclass { MIPS_GR_REG, MIPS_FP_REG, MIPS16_REG };
>
I'd also get rid of all uses of internalError() in tc-mips.c and
simply use abort(). See as.h definition of abort().
I'll preapprove that change if you care to make it.
--
Alan Modra
Australia Development Lab, IBM