This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: invocation of mips_elf_multi_got can cause not enough GOT space for local GOT entries
Robert Schiele <rschiele@gmail.com> writes:
> On Mon, Jan 14, 2013 at 2:47 PM, Richard Sandiford
> <rdsandiford@googlemail.com> wrote:
>> You'll need to do it consistently for all page_gotno tests
>> (mips_elf_merge_got_with, mips_elf_merge_gots, mips_elf_multi_got and
>> mips_elf_lay_out_got), otherwise you could end up merging GOTs based on
>> the current estimate and lay them out using the conservative one, which
>> could lead to overflow in the global region. But yeah, I think you'd
>> be safe changing those four places, as a local hack to get round the bug.
>
> So, with consistent you mean something like this?
Yeah, that looks good.
Richard