This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFA 3/5] New port: CR16: gdb port
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Kaushik Phatak <Kaushik dot Phatak at kpitcummins dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>, "binutils at sourceware dot org" <binutils at sourceware dot org>, Pedro Alves <palves at redhat dot com>, Yao Qi <yao at codesourcery dot com>, nick clifton <nickc at redhat dot com>, Tom Tromey <tromey at redhat dot com>
- Date: Fri, 18 Jan 2013 18:16:49 +0400
- Subject: Re: [RFA 3/5] New port: CR16: gdb port
- References: <20121022224107.GB3713@adacore.com> <C6CA53A2A46BA7469348BDBD663AB65845B3E44A@KCHJEXMB02.kpit.com> <20121023135502.GA3555@adacore.com> <C6CA53A2A46BA7469348BDBD663AB65845B3EB9E@KCHJEXMB02.kpit.com> <20121115174313.GC3790@adacore.com> <C6CA53A2A46BA7469348BDBD663AB65845B614E5@KCHJEXMB02.kpit.com> <20121122175010.GG9964@adacore.com> <C6CA53A2A46BA7469348BDBD663AB65848567829@KCHJEXMB02.kpit.com> <20130117085919.GA3564@adacore.com> <C6CA53A2A46BA7469348BDBD663AB65848569146@KCHJEXMB02.kpit.com>
> Thanks for spending time on this. I have tried to address all your
> points in this updated patch.
And I confirm you did :).
> 2013-01-18 Kaushik Phatak <kaushik.phatak@kpitcummins.com>
> gdb/Changelog
> * configure.tgt: Handle cr16*-*-*linux and cr16*-*-*.
> * cr16-linux-tdep.c: New file.
> * cr16-tdep.c: New file.
> * cr16-tdep.h: New file.
Looks good to me.
One warning, though: You added src/configure.ac and src/configure
to the patch. JIC we hadn't mentioned this, this part is controlled
by GCC, and needs to be approved there. You can go ahead and commit
the GDB part.
--
Joel