This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[PATCH][GAS][ARM] Fix disassembly of strht

From: "Kyrylo Tkachov" <kyrylo dot tkachov at arm dot com>
To: <binutils at sourceware dot org>
Cc: "Richard Earnshaw" <Richard dot Earnshaw at arm dot com>, "'nick clifton'" <nickc at redhat dot com>
Date: Fri, 1 Feb 2013 11:03:55 -0000
Subject: [PATCH][GAS][ARM] Fix disassembly of strht

Hi all,
gas disassembles a form of the strht ARM instruction improperly:

strht r0, [r1], -r2 @ assembles to E02100B2
@ disassembles as "strh r0, [r1], -r2 ; UNPREDICTABLE"
strht r0, [r1], r2 @ assembles to E0A100B2
@ disassembles as "strh r0, [r1], r2 ; UNPREDICTABLE"

This patch fixes that. New tests are added for that case, and also for the
similar ldrht instruction.

Ok for trunk?

Thanks,
Kyrill

opcodes/ChangeLog

2013-02-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	* arm-dis.c: Add another pattern for strht.


gas/testsuite/ChangeLog

2013-02-01  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>

	* gas/arm/archv6t2.s: Add strht and ldrht tests.
	* gas/arm/archv6t2.d: Add disassembly patterns for the above.

Attachment: gas-strht.txt
Description: Text document

Follow-Ups:
- Re: [PATCH][GAS][ARM] Fix disassembly of strht
  - From: Richard Earnshaw
- Re: [PATCH][GAS][ARM] Fix disassembly of strht
  - From: nick clifton

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]