This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [GOLD] powerpc linker generated .eh_frame

On Wed, Feb 27, 2013 at 06:22:34AM -0800, Ian Lance Taylor wrote:
> > +  ~Post_fde();
> 
> I don't see where this is defined.  I also don't see why the default
> destructor isn't fine.  Can you just omit this line?

Ick, I'm not sure how that got there.

> > +  Fde* fde_;
> > +  section_offset_type cie_offset_;
> > +  unsigned char fde_encoding_;
> > +};
> 
> Make the class member variables private.  Or make this a struct, in
> which case remove the trailing underscores from the field names.

I've made it a struct.

-- 
Alan Modra
Australia Development Lab, IBM
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]