This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix sleb128 encoding for difference expressions


On Mon, Apr 08, 2013 at 03:59:55PM +0930, Alan Modra wrote:
> On Mon, Apr 08, 2013 at 02:34:13PM +0930, Alan Modra wrote:
> > On Fri, Apr 05, 2013 at 05:00:02PM +0100, Julian Brown wrote:
> > > > > On Mon, 12 Nov 2012 12:19:18 +0000
> > > > > Julian Brown <julian@codesourcery.com> wrote:
> > > > > > This is a more conservative version of the patch, which *only*
> > > > > > affects assembly of .sleb128 directives.
> > 
> > That one was http://sourceware.org/ml/binutils/2012-11/msg00141.html
> > 
> > It still applies, but I see testsuite failures on x86_64-linux.
> > 
> > First one is:
> > regexp_diff match failure
> > regexp "^ 0000 7d2a0000 00000000 00000000 00000000  .*$"
> > line   " 0000 7d2a                                 }*              "
> > FAIL: .sleb128 tests (2)
> > 
> > I'd suggest making the match
> >  0+ 7d2a.*
> > and similarly with other testcases.
> > 
> > Patch is OK with those changes.
> 
> Oh, and another thing I just noticed, you need to ensure these tests
> are only run on ELF targets.  Probably best to move them to
> gas/testsuite/gas/elf/

Oops, no, sorry.  We do support .sleb128 on non-ELF.  But AOUT for
instance typically won't have .data starting at zero for your
testcases..  So my suggestion to use 0+ wasn't quite correct.

.* 7d2a.*
instead.

-- 
Alan Modra
Australia Development Lab, IBM


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]