This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH v2] arm: properly range check immediate operands of VSHL and VQSHL

From: Richard Earnshaw <rearnsha at arm dot com>
To: Jan Beulich <JBeulich at suse dot com>
Cc: "paul at codesourcery dot com" <paul at codesourcery dot com>, "nickc at redhat dot com" <nickc at redhat dot com>, "binutils at sourceware dot org" <binutils at sourceware dot org>
Date: Wed, 10 Apr 2013 13:36:32 +0100
Subject: Re: [PATCH v2] arm: properly range check immediate operands of VSHL and VQSHL
References: <516301B602000078000CB677 at nat28 dot tlf dot novell dot com> <51655ECD02000078000CC0BD at nat28 dot tlf dot novell dot com>

On 10/04/13 11:45, Jan Beulich wrote:

These two, other than VQSHLU, didn't have their immediates properly range
checked so far.

gas/
2013-04-10  Jan Beulich <jbeulich@suse.com>

	* gas/config/tc-arm.c (do_neon_shl_imm): Check immediate range.
	(do_neon_qshl_imm): Likewise.

gas/testsuite/
2013-04-10  Jan Beulich <jbeulich@suse.com>

	* gas/arm/neon-addressing-bad.s: Add test for invalid VSHL,
	VQSHL, and VQSHLU immediates.
	* gas/arm/neon-addressing-bad.l: Update accordingly.

neon-addressing-bad is really checking addressing modes forloads/stores. I'd prefer these new checks to be in a separate file;perhaps neon-dataproc-bad.


OK with that change.

R.

Follow-Ups:
- Re: [PATCH v2] arm: properly range check immediate operands of VSHL and VQSHL
  - From: Jan Beulich

References:
- [PATCH] arm: properly range check immediate operands of VSHL and VQSHL
  - From: Jan Beulich
- [PATCH v2] arm: properly range check immediate operands of VSHL and VQSHL
  - From: Jan Beulich

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]