This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Commit: Create a single linker script for DWARF sections


Hi!

On Mon, 15 Apr 2013 09:45:53 +0100, Nick Clifton <nickc@redhat.com> wrote:
>   [...] I created the
>   patch below which creates a single DWARF.sc script fragment which is
>   then included into any script that uses DWARF sections.

> 	* scripttempl/armbpabi.sc: Replace DWARF sections with an
> 	inclusion of DWARF.sc.
> 	* scripttempl/avr.sc: Likewise.
> 	* [...]

Using dash, this patch causes one "regression".  I'm putting regression
in quotes, because it does not in fact cause a build failure (I think it
should), or any observable regression in the testsuite -- though, in fact
the generated ld/*.c and ld/ldscripts/*.x* files did not contain the
statements for handling the DWARF information.

    LIB_PATH='' /bin/dash [...]/ld/genscripts.sh "[...]/ld" "[...]/lib" "[...]" "[...]" i686-pc-linux-gnu i686-pc-linux-gnu i686-pc-linux-gnu "elf_i386 elf32_x86_64" "/usr/local/lib /lib /usr/lib" yes yes elf_i386 "i686-pc-linux-gnu"
    [...]/ld/genscripts.sh: 641: ../../Paul_Desmond/ld/scripttempl/elf.sc: source: not found
    [...]/ld/genscripts.sh: 641: ../../Paul_Desmond/ld/scripttempl/elf.sc: source: not found
    [And so on.]

I committed the obvious patch to replace Âsource usage with Â.Â, as used
elsewhere in the scripttempl files.

ld/
	* scripttempl/armbpabi.sc: Replace "source" usage with ".".
	* scripttempl/avr.sc: Likewise.
	* scripttempl/elf.sc: Likewise.
	* scripttempl/elf32cr16.sc: Likewise.
	* scripttempl/elf32crx.sc: Likewise.
	* scripttempl/elf32msp430.sc: Likewise.
	* scripttempl/elf32msp430_3.sc: Likewise.
	* scripttempl/elf32sh-symbian.sc: Likewise.
	* scripttempl/elf64hppa.sc: Likewise.
	* scripttempl/elf_chaos.sc: Likewise.
	* scripttempl/elfd10v.sc: Likewise.
	* scripttempl/elfd30v.sc: Likewise.
	* scripttempl/elfi370.sc: Likewise.
	* scripttempl/elfm68hc11.sc: Likewise.
	* scripttempl/elfm68hc12.sc: Likewise.
	* scripttempl/elfxgate.sc: Likewise.
	* scripttempl/elfxtensa.sc: Likewise.
	* scripttempl/epiphany_4x4.sc: Likewise.
	* scripttempl/i386beos.sc: Likewise.
	* scripttempl/i386go32.sc: Likewise.
	* scripttempl/ia64vms.sc: Likewise.
	* scripttempl/ip2k.sc: Likewise.
	* scripttempl/iq2000.sc: Likewise.
	* scripttempl/mep.sc: Likewise.
	* scripttempl/mmo.sc: Likewise.
	* scripttempl/v850.sc: Likewise.
	* scripttempl/v850_rh850.sc: Likewise.
	* scripttempl/xstormy16.sc: Likewise.

diff --git ld/scripttempl/armbpabi.sc ld/scripttempl/armbpabi.sc
index 3956b60..a1bbc2b 100644
--- ld/scripttempl/armbpabi.sc
+++ ld/scripttempl/armbpabi.sc
@@ -327,7 +327,7 @@ cat <<EOF
   .comment       0 : { *(.comment) }
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   ${STACK_ADDR+${STACK}}
diff --git ld/scripttempl/avr.sc ld/scripttempl/avr.sc
index eac55b3..2ecbd2c 100644
--- ld/scripttempl/avr.sc
+++ ld/scripttempl/avr.sc
@@ -237,7 +237,7 @@ SECTIONS
   .note.gnu.build-id : { *(.note.gnu.build-id) }
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/elf.sc ld/scripttempl/elf.sc
index 4868d3e..feb118d 100644
--- ld/scripttempl/elf.sc
+++ ld/scripttempl/elf.sc
@@ -638,7 +638,7 @@ cat <<EOF
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 
diff --git ld/scripttempl/elf32cr16.sc ld/scripttempl/elf32cr16.sc
index e709312..0b0bb9c 100644
--- ld/scripttempl/elf32cr16.sc
+++ ld/scripttempl/elf32cr16.sc
@@ -152,7 +152,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/elf32crx.sc ld/scripttempl/elf32crx.sc
index 5040b5e..02c6fb4 100644
--- ld/scripttempl/elf32crx.sc
+++ ld/scripttempl/elf32crx.sc
@@ -154,7 +154,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/elf32msp430.sc ld/scripttempl/elf32msp430.sc
index bde7fb4..53a87b8 100644
--- ld/scripttempl/elf32msp430.sc
+++ ld/scripttempl/elf32msp430.sc
@@ -217,7 +217,7 @@ SECTIONS
  
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   PROVIDE (__stack = ${STACK}) ;
diff --git ld/scripttempl/elf32msp430_3.sc ld/scripttempl/elf32msp430_3.sc
index cdc691a..9a23d02 100644
--- ld/scripttempl/elf32msp430_3.sc
+++ ld/scripttempl/elf32msp430_3.sc
@@ -163,7 +163,7 @@ SECTIONS
  
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   PROVIDE (__stack = ${STACK}) ;
diff --git ld/scripttempl/elf32sh-symbian.sc ld/scripttempl/elf32sh-symbian.sc
index 53df36e..680028f 100644
--- ld/scripttempl/elf32sh-symbian.sc
+++ ld/scripttempl/elf32sh-symbian.sc
@@ -349,7 +349,7 @@ cat <<EOF
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   ${STACK_ADDR+${STACK}}
diff --git ld/scripttempl/elf64hppa.sc ld/scripttempl/elf64hppa.sc
index c3b170e..d529f8d 100644
--- ld/scripttempl/elf64hppa.sc
+++ ld/scripttempl/elf64hppa.sc
@@ -531,7 +531,7 @@ cat <<EOF
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   ${TINY_DATA_SECTION}
diff --git ld/scripttempl/elf_chaos.sc ld/scripttempl/elf_chaos.sc
index d376513..621352f 100644
--- ld/scripttempl/elf_chaos.sc
+++ ld/scripttempl/elf_chaos.sc
@@ -321,7 +321,7 @@ cat <<EOF
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   ${STACK_ADDR+${STACK}}
diff --git ld/scripttempl/elfd10v.sc ld/scripttempl/elfd10v.sc
index 42450e0..81143b5 100644
--- ld/scripttempl/elfd10v.sc
+++ ld/scripttempl/elfd10v.sc
@@ -166,7 +166,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/elfd30v.sc ld/scripttempl/elfd30v.sc
index 7f185a5..1038290 100644
--- ld/scripttempl/elfd30v.sc
+++ ld/scripttempl/elfd30v.sc
@@ -193,7 +193,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF  
   PROVIDE (__stack = ${STACK_START_ADDR});
diff --git ld/scripttempl/elfi370.sc ld/scripttempl/elfi370.sc
index d36483f..900ee09 100644
--- ld/scripttempl/elfi370.sc
+++ ld/scripttempl/elfi370.sc
@@ -185,7 +185,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF  
   ${ATTRS_SECTIONS}
diff --git ld/scripttempl/elfm68hc11.sc ld/scripttempl/elfm68hc11.sc
index 001f921..e839227 100644
--- ld/scripttempl/elfm68hc11.sc
+++ ld/scripttempl/elfm68hc11.sc
@@ -430,7 +430,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/elfm68hc12.sc ld/scripttempl/elfm68hc12.sc
index 315ba9b..a737481 100644
--- ld/scripttempl/elfm68hc12.sc
+++ ld/scripttempl/elfm68hc12.sc
@@ -437,7 +437,7 @@ SECTIONS
      symbols are found.  */
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/elfxgate.sc ld/scripttempl/elfxgate.sc
index 8e7e650..d61b9dd 100644
--- ld/scripttempl/elfxgate.sc
+++ ld/scripttempl/elfxgate.sc
@@ -433,7 +433,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/elfxtensa.sc ld/scripttempl/elfxtensa.sc
index 678b745..b51fe6a 100644
--- ld/scripttempl/elfxtensa.sc
+++ ld/scripttempl/elfxtensa.sc
@@ -541,7 +541,7 @@ cat <<EOF
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   ${TINY_DATA_SECTION}
diff --git ld/scripttempl/epiphany_4x4.sc ld/scripttempl/epiphany_4x4.sc
index 3be6f4e..b577ef8 100644
--- ld/scripttempl/epiphany_4x4.sc
+++ ld/scripttempl/epiphany_4x4.sc
@@ -627,7 +627,7 @@ cat <<EOF
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   ${TINY_DATA_SECTION}
diff --git ld/scripttempl/i386beos.sc ld/scripttempl/i386beos.sc
index 200c50b..a8bbd37 100644
--- ld/scripttempl/i386beos.sc
+++ ld/scripttempl/i386beos.sc
@@ -162,7 +162,7 @@ SECTIONS
   }
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/i386go32.sc ld/scripttempl/i386go32.sc
index d86e82e..fce4cec 100644
--- ld/scripttempl/i386go32.sc
+++ ld/scripttempl/i386go32.sc
@@ -67,7 +67,7 @@ SECTIONS
   .stabstr 0 : { *(.stabstr) }
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/ia64vms.sc ld/scripttempl/ia64vms.sc
index b8be91f..cdda6b2 100644
--- ld/scripttempl/ia64vms.sc
+++ ld/scripttempl/ia64vms.sc
@@ -106,7 +106,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF  
   .note : { *(.vms.note) }
diff --git ld/scripttempl/ip2k.sc ld/scripttempl/ip2k.sc
index a3b0840..1b7f77b 100644
--- ld/scripttempl/ip2k.sc
+++ ld/scripttempl/ip2k.sc
@@ -131,7 +131,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
 }
diff --git ld/scripttempl/iq2000.sc ld/scripttempl/iq2000.sc
index 764b20f..fe1f21d 100644
--- ld/scripttempl/iq2000.sc
+++ ld/scripttempl/iq2000.sc
@@ -407,7 +407,7 @@ cat <<EOF
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   ${RELOCATING+${OTHER_RELOCATING_SECTIONS}}
diff --git ld/scripttempl/mep.sc ld/scripttempl/mep.sc
index ba4ccc8..cf85f76 100644
--- ld/scripttempl/mep.sc
+++ ld/scripttempl/mep.sc
@@ -407,7 +407,7 @@ cat <<EOF
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   ${STACK_ADDR+${STACK}}
diff --git ld/scripttempl/mmo.sc ld/scripttempl/mmo.sc
index 056e91c..6671cce 100644
--- ld/scripttempl/mmo.sc
+++ ld/scripttempl/mmo.sc
@@ -114,7 +114,7 @@ SECTIONS
   .stab.indexstr 0 : { *(.stab.indexstr) }
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   .MMIX.reg_contents :
diff --git ld/scripttempl/v850.sc ld/scripttempl/v850.sc
index 642e6ba..4af97e4 100644
--- ld/scripttempl/v850.sc
+++ ld/scripttempl/v850.sc
@@ -193,7 +193,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   /* User stack.  */
diff --git ld/scripttempl/v850_rh850.sc ld/scripttempl/v850_rh850.sc
index 949b2e9..1b8635f 100644
--- ld/scripttempl/v850_rh850.sc
+++ ld/scripttempl/v850_rh850.sc
@@ -213,7 +213,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   /* User stack.  */
diff --git ld/scripttempl/xstormy16.sc ld/scripttempl/xstormy16.sc
index 2ae460d..b285751 100644
--- ld/scripttempl/xstormy16.sc
+++ ld/scripttempl/xstormy16.sc
@@ -204,7 +204,7 @@ SECTIONS
 
 EOF
 
-source $srcdir/scripttempl/DWARF.sc
+. $srcdir/scripttempl/DWARF.sc
 
 cat <<EOF
   ${RELOCATING+${OTHER_RELOCATING_SECTIONS}}


GrÃÃe,
 Thomas

Attachment: pgp5zVPQXca6Y.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]