This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] TILEPro/BFD: Don't crash on discarded GOT
- From: "Maciej W. Rozycki" <macro at linux-mips dot org>
- To: binutils at sourceware dot org
- Cc: nick clifton <nickc at redhat dot com>, Walter Lee <walt at tilera dot com>
- Date: Sat, 27 Jul 2013 23:50:59 +0100 (BST)
- Subject: [PATCH] TILEPro/BFD: Don't crash on discarded GOT
- References: <alpine dot LFD dot 2 dot 03 dot 1305200339380 dot 10753 at linux-mips dot org> <51B207B2 dot 30702 at redhat dot com> <alpine dot LFD dot 2 dot 03 dot 1307272329140 dot 3015 at linux-mips dot org>
Hi,
This change fixes a linker crash where GOT is produced but not copied to
output, e.g. because of the .got.plt input section being discarded through
the /DISCARD/ linker script keyword -- not a particularly useful use case,
but the linker shouldn't crash regardless.
OK to apply?
2013-07-27 Maciej W. Rozycki <macro@linux-mips.org>
bfd/
* elf32-tilepro.c (tilepro_elf_finish_dynamic_sections): Don't set
GOT's entry size if there is no ELF section data.
Maciej
binutils-2.23.52-20130506-tilepro-finish-dynamic.patch
Index: binutils/bfd/elf32-tilepro.c
===================================================================
--- binutils.orig/bfd/elf32-tilepro.c
+++ binutils/bfd/elf32-tilepro.c
@@ -3909,8 +3909,9 @@ tilepro_elf_finish_dynamic_sections (bfd
PLT_ENTRY_SIZE - PLT_HEADER_SIZE);
}
- elf_section_data (splt->output_section)->this_hdr.sh_entsize
- = PLT_ENTRY_SIZE;
+ if (elf_section_data (splt->output_section) != NULL)
+ elf_section_data (splt->output_section)->this_hdr.sh_entsize
+ = PLT_ENTRY_SIZE;
}
if (htab->elf.sgotplt)