This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] x86: fix build when REGISTER_WARNINGS is zero
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Beulich <JBeulich at suse dot com>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 8 Oct 2013 08:12:42 -0700
- Subject: Re: [PATCH] x86: fix build when REGISTER_WARNINGS is zero
- Authentication-results: sourceware.org; auth=none
- References: <52542C3902000078000F9A1B at nat28 dot tlf dot novell dot com>
On Tue, Oct 8, 2013 at 7:00 AM, Jan Beulich <JBeulich@suse.com> wrote:
> This was broken due to a misplaced "else".
>
> gas/
> 2013-10-08 Jan Beulich <jbeulich@suse.com>
>
> * tc-i386.c (check_word_reg): Remove misplaced "else".
> (check_long_reg): Restore symmetry with check_word_reg.
>
> --- 2013-10-07/gas/config/tc-i386.c
> +++ 2013-10-07/gas/config/tc-i386.c
> @@ -5434,13 +5434,10 @@ check_long_reg (void)
> return 0;
> }
> #if REGISTER_WARNINGS
> - else
> - as_warn (_("using `%s%s' instead of `%s%s' due to `%c' suffix"),
> - register_prefix,
> - (i.op[op].regs + REGNAM_EAX - REGNAM_AX)->reg_name,
> - register_prefix,
> - i.op[op].regs->reg_name,
> - i.suffix);
> + as_warn (_("using `%s%s' instead of `%s%s' due to `%c' suffix"),
> + register_prefix,
> + (i.op[op].regs + REGNAM_EAX - REGNAM_AX)->reg_name,
> + register_prefix, i.op[op].regs->reg_name, i.suffix);
> #endif
> }
> /* Warn if the r prefix on a general reg is missing. */
> @@ -5546,14 +5543,11 @@ check_word_reg (void)
> i.suffix);
> return 0;
> }
> - else
> #if REGISTER_WARNINGS
> - as_warn (_("using `%s%s' instead of `%s%s' due to `%c' suffix"),
> - register_prefix,
> - (i.op[op].regs + REGNAM_AX - REGNAM_EAX)->reg_name,
> - register_prefix,
> - i.op[op].regs->reg_name,
> - i.suffix);
> + as_warn (_("using `%s%s' instead of `%s%s' due to `%c' suffix"),
> + register_prefix,
> + (i.op[op].regs + REGNAM_AX - REGNAM_EAX)->reg_name,
> + register_prefix, i.op[op].regs->reg_name, i.suffix);
> #endif
> }
> return 1;
>
>
>
It is OK.
Thanks.
--
H.J.