This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] MIPS SIMD Architecture (MSA) patch
- From: Richard Sandiford <rdsandiford at googlemail dot com>
- To: "Maciej W. Rozycki" <macro at codesourcery dot com>
- Cc: Chao-Ying Fu <Chao-Ying dot Fu at imgtec dot com>, "binutils\ at sourceware dot org" <binutils at sourceware dot org>
- Date: Tue, 08 Oct 2013 20:23:02 +0100
- Subject: Re: [PATCH] MIPS SIMD Architecture (MSA) patch
- Authentication-results: sourceware.org; auth=none
- References: <81D57523CB07B24881D63DE650C6ED82019034B4 at BADAG02 dot ba dot imgtec dot org> <alpine dot DEB dot 1 dot 10 dot 1310081252290 dot 6696 at tp dot orcam dot me dot uk>
"Maciej W. Rozycki" <macro@codesourcery.com> writes:
>> Index: opcodes/mips-dis.c
>> ===================================================================
>> RCS file: /cvs/src/src/opcodes/mips-dis.c,v
>> retrieving revision 1.116
>> diff -u -p -r1.116 mips-dis.c
>> --- opcodes/mips-dis.c 19 Aug 2013 18:56:59 -0000 1.116
>> +++ opcodes/mips-dis.c 8 Oct 2013 00:30:27 -0000
>> @@ -738,10 +747,22 @@ parse_mips_dis_option (const char *optio
> [...]
>> if (CONST_STRNEQ (option, "virt"))
>> {
>> mips_ase |= ASE_VIRT;
>> - if (mips_isa & ISA_MIPS64R2)
>> + if ((mips_isa & INSN_ISA_MASK) == ISA_MIPS64R2)
>> mips_ase |= ASE_VIRT64;
>> return;
>> }
>
> This looks like an unrelated bug fix to me that should be applied
> separately.
Yeah, this part is OK on its own, thanks. I think both it and your
earlier encoding fix should go on 2.24 too.
Richard