This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [RFC] BFD MinGW/Cygwin build error in bfd/peiXXgen.c
- From: Pedro Alves <palves at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "'asmwarrior'" <asmwarrior at gmail dot com>, "'GDB Development'" <gdb at sourceware dot org>, "'Binutils Development'" <binutils at sourceware dot org>
- Date: Wed, 18 Dec 2013 17:56:00 +0000
- Subject: Re: [RFC] BFD MinGW/Cygwin build error in bfd/peiXXgen.c
- Authentication-results: sourceware.org; auth=none
- References: <52B17083 dot 7040404 at gmail dot com> <52B1738D dot 4010409 at redhat dot com> <52b19d19 dot 0850420a dot 7b6a dot 52dcSMTPIN_ADDED_BROKEN at mx dot google dot com>
On 12/18/2013 01:02 PM, Pierre Muller wrote:
> -#ifdef __CYGWIN__
> +#if defined __CYGWIN__ || defined __MINGW32__
> +#ifdef __MINGW32__
> +#define wcsncasecmp wcsnicmp
> +#endif
> /* Under Cygwin unicode == UTF-16 == wchar_t.
> FIXME: The same is true for MingGW - we should test for that too. */
Isn't this FIXME note stale now?
> + bfd_byte * astring = a->name_id.name.string;
> + unsigned int alen = a->name_id.name.len;
> + bfd_byte * bstring = b->name_id.name.string;
> + unsigned int blen = b->name_id.name.len;
> res = wcsncasecmp ((const wchar_t *) astring + 2, (const wchar_t *) bstring + 2, min (alen, blen));
> #elif defined HAVE_WCHAR_H
> unsigned int i;
--
Pedro Alves