This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [ Bug 16340][AARCH64][PATCH] Offset into GOT for TLS relocation computed inconsistently
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: Kugan <kugan dot vivekanandarajah at linaro dot org>
- Cc: binutils at sourceware dot org, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Michael Hudson-Doyle <michael dot hudson at linaro dot org>, "patches at linaro dot org" <patches at linaro dot org>
- Date: Mon, 13 Jan 2014 16:36:41 +0100
- Subject: Re: [ Bug 16340][AARCH64][PATCH] Offset into GOT for TLS relocation computed inconsistently
- Authentication-results: sourceware.org; auth=none
- References: <52B29EF7 dot 7040209 at linaro dot org> <52B4008F dot 1000403 at linaro dot org> <20131222014713 dot GE7521 at bubble dot grove dot modra dot org> <52BE28AA dot 2000204 at linaro dot org>
On 28 December 2013 02:26, Kugan <kugan.vivekanandarajah@linaro.org> wrote:
> On 22/12/13 12:47, Alan Modra wrote:
>> On Fri, Dec 20, 2013 at 07:32:15PM +1100, Kugan wrote:
>>> [Apologies if you get this twice; Noticed a typo with email address]
>>>
>>> Hi,
>>>
>>> mongodb for aarch64 segfaults due to an error in applying GOT for TLS
>>> relocation. Michael Hudson-Doyle tracked this down to wrong usage of
>>> offset for the relocation. Attached patch (by Michael Hudson-Doyle)
>>> fixes this. Regression tested on aarch64-none-linux-gnu with no new
>>> regressions.
>>>
>>> Is this OK for trunk and backport for 2.24?
>>
>> Looks good to me. There are two more occurrences of
>> output_section->output_offset in elfnn-aarch64.c. Please fix those
>> too.
>>
>
> Thanks Alan for the review. Please fond the patch attached which changes
> it. make check for binutils, gas and ld has no new regression with the
> patch.
>
Hi Alan,
Is this version OK?
Thanks,
Christophe.
> Thanks,
> Kugan
>
> bfd/
> +2013-12-28 Michael Hudson-Doyle <michael.hudson@linaro.org>
> +
> + * elfnn-aarch64.c (elfNN_aarch64_final_link_relocate): Use correct
> + offset while calculating relocation address.
> + * elfnn-aarch64.c (elfNN_aarch64_create_small_pltn_entry): Use correct
> + offset while calculating relocation address.
> +
>