This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC PATCH] bfd/elf32-arm.c: Set st_value to zero for undefined symbols.


On 24 January 2014 04:17, Alan Modra <amodra@gmail.com> wrote:
> On Thu, Jan 23, 2014 at 03:22:21PM +0000, Will Newton wrote:
>> On 16 January 2014 10:28, Will Newton <will.newton@linaro.org> wrote:
>> > I'm not sure what the implications of this patch are, so I thought I would
>> > post it here in the hope that someone can explain what might break.
>
> You're probably being a bit too honest here. :)
>
> The patch looks OK to me as far as it goes, but I count myself
> unqualified to ack it.  I don't know enough about ARM to say whether
> you've set pointer_equality_needed for all the relocs types you
> should.  It needs to be set whenever you might be taking the address
> of a function in non-PIC code or data.

Thanks, I wasn't sure of the semantics of pointer_equality_needed.
I'll investigate and post an updated patch.

-- 
Will Newton
Toolchain Working Group, Linaro


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]