This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch bfd] Remove unneeded comma expression from bfd_set_section_userdata, bfd_set_section_alignment, bfd_set_section_vma


>>>>> "Ramana" == Ramana Radhakrishnan <ramrad01@arm.com> writes:

Ramana> Uggh, it looks like I didn't test when the hunks included
Ramana> bfd_set_section_vma and bfd_set_section_alignment because this expects
Ramana> the TRUE to be meaningful and uses that in conditions in a number of
Ramana> places.

Ramana> The problem though is real and builds appear to be broken with
Ramana> trunk gcc.

I wonder if it would be acceptable to replace it with a static inline
function.  I think that would avoid the warning.  "static inline" is
already unconditionally used in BFD, so I don't think there's a
portability issue.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]