This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR gas/16488: Add test for incorrect memory operand for gather/scatter instructions.


On Fri, Jan 31, 2014 at 2:09 AM, Michael V. Zolotukhin
<michael.v.zolotukhin@gmail.com> wrote:
> Hi,
>
> This patch adds test for incorrect memory operand for gather/scatter
> instructions, thusly fixing PR16488.  Ok for trunk?
>
> gas/testsuite/ChangeLog:
> 2014-01-31  Michael Zolotukhin  <michael.v.zolotukhin@gmail.com>
>
>         PR gas/16488
>         * gas/i386/inval-avx512f.s: Add test for incorrect memory operand for
>         gather/scatter instructions.
>         * gas/i386/x86-64-inval-avx512f.s: Likewise.
>         * gas/i386/inval-avx512f.l: Adjust correspondingly.
>         * gas/i386/x86-64-inval-avx512f.l: Likewise.
>
> Thanks,
> Michael
>

> diff --git a/gas/testsuite/gas/i386/inval-avx512f.s b/gas/testsuite/gas/i386/inval-avx512f.s
> index b1ddba4..7c9b1d6 100644
> --- a/gas/testsuite/gas/i386/inval-avx512f.s
> +++ b/gas/testsuite/gas/i386/inval-avx512f.s
> @@ -15,6 +15,8 @@ _start:
>         vcvtps2pd (%eax){z}, %zmm1
>
>         vgatherqpd (%rdi,%zmm2,8),%zmm6
> +       vgatherqpd (%edi),%zmm6{%k1}
> +       vgatherqpd (%zmm2),%zmm6{%k1}
>
>         .intel_syntax noprefix
>         mov eax{k1}, {sae}
> @@ -31,6 +33,7 @@ _start:
>         vcvtps2pd zmm1, [eax]{z}
>
>         vgatherqpd zmm6, ZMMWORD PTR [rdi+zmm2*8]
> +       vgatherqpd zmm6{k1}, ZMMWORD PTR [edi]
>
>         vaddps zmm2, zmm1, QWORD PTR [eax]{1to8}
>         vaddps zmm2, zmm1, QWORD PTR [eax]{1to16}
> diff --git a/gas/testsuite/gas/i386/x86-64-inval-avx512f.s b/gas/testsuite/gas/i386/x86-64-inval-avx512f.s
> index 5ac7349..9e8823e 100644
> --- a/gas/testsuite/gas/i386/x86-64-inval-avx512f.s
> +++ b/gas/testsuite/gas/i386/x86-64-inval-avx512f.s
> @@ -14,6 +14,9 @@ _start:
>         vcvtps2pd (%rax){%k1}, %zmm1
>         vcvtps2pd (%rax){z}, %zmm1
>
> +       vgatherqpd (%rdi),%zmm6{%k1}
> +       vgatherqpd (%zmm2),%zmm6{%k1}
> +
>         .intel_syntax noprefix
>         mov rax{k1}, {sae}
>         mov rax, {sae}
> @@ -28,6 +31,8 @@ _start:
>         vcvtps2pd zmm1, [rax]{k1}
>         vcvtps2pd zmm1, [rax]{z}
>
> +       vgatherqpd zmm6{k1}, ZMMWORD PTR [rdi]
> +
>         vaddps zmm2, zmm1, QWORD PTR [rax]{1to8}
>         vaddps zmm2, zmm1, QWORD PTR [rax]{1to16}
>         vaddpd zmm2, zmm1, DWORD PTR [rax]{1to8}

You added 2 tests for AT&T syntax, but only 1 for
Intel syntax.  Any particular reason for this?

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]