This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFC][PATCH] Handle arbitrary .plt/.got displacements in ld on ARM

From: nick clifton <nickc at redhat dot com>
To: Yury Gribov <y dot gribov at samsung dot com>, Will Newton <will dot newton at linaro dot org>
Cc: "binutils at sourceware dot org" <binutils at sourceware dot org>, Viacheslav Garbuzov <v dot garbuzov at samsung dot com>, Yuri Gribov <tetra2005 at gmail dot com>
Date: Fri, 21 Feb 2014 14:20:15 +0000
Subject: Re: [RFC][PATCH] Handle arbitrary .plt/.got displacements in ld on ARM
Authentication-results: sourceware.org; auth=none
References: <52F4B2B3 dot 8060804 at samsung dot com> <CANu=Dmh_amrVpf_hQMt2CsnLdTbxv78muPLBi3U_WGS-XE7kSQ at mail dot gmail dot com> <52F8BD92 dot 5080609 at samsung dot com>

Hi Yury,

Added ld/testsuite/ld-arm/long-plt-format.{s,d}. BTW are there any
guidelines for writing tests? I was unable to find any...

The only guideline is "follow what has been done before". Since youhave done this, the new test looks fine.

I wonder however whether it would be possible to remove the new commandline option and have the linker automatically decide between using28-bit or 32-bit PLT entries ? Presumably this would require a scan ofthe entries first, or maybe just the sizes of the object files, but Ithink that users would prefer to have something that just works ratherthan having to learn a new linker command line option.


Cheers
  Nick

Follow-Ups:
- Re: [RFC][PATCH] Handle arbitrary .plt/.got displacements in ld on ARM
  - From: Yury Gribov

References:
- [RFC][PATCH] Handle arbitrary .plt/.got displacements in ld on ARM
  - From: Yury Gribov
- Re: [RFC][PATCH] Handle arbitrary .plt/.got displacements in ld on ARM
  - From: Will Newton
- Re: [RFC][PATCH] Handle arbitrary .plt/.got displacements in ld on ARM
  - From: Yury Gribov

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]