This is the mail archive of the
cgen@sources.redhat.com
mailing list for the CGEN project.
Re: [Patch] More thorough cpu.h hardware struct
- To: "Frank Ch. Eigler" <fche at redhat dot com>
- Subject: Re: [Patch] More thorough cpu.h hardware struct
- From: Ben Elliston <bje at redhat dot com>
- Date: Fri, 24 Nov 2000 12:58:05 +1100 (EST)
- Cc: <cgen at sources dot redhat dot com>
The -gen-hardware-struct thingie already filters hw objects for
hw-need-storage?-ness, so it's redundant to do it in the caller too.
Ah yes.
Also, I would push the conditional down a few layers, since the two
arms share a lot. Something like:
[...]
Thanks. I've made the changes you've suggest and will check in the revised
patch once I have tested it on another port.
(By the way, untabified text survives email editing better.)
Stupid X cut and paste. Sorry.
Ben