This is the mail archive of the cgen@sources.redhat.com mailing list for the CGEN project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: branch probability hinting


"Frank Ch. Eigler" <fche@redhat.com> writes:

> One is used thusly (and the other, vice versa):
> [ ... ]
> 		if UNLIKELY(error) {

Cool.  Only one nit to pick:

Please don't encourage people to write code that appears to be
syntactically invalid.  I know that the parens are part of the
expansion of LIKELY & UNLIKELY, but lexical tools such as indent get
confused.  I'd rather see uses like this:

		if (UNLIKELY(error)) {

Greg


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]