Re: [PATCH] Updated NPTL toolchain patch...

[Daniel Kegel <dank at kegel dot com>]

Jean-Christophe Dubois wrote:
> > > This allows the script to complete successfully on Solaris (and I guess
> > > on any other platform). I still have to test the resulting tool chain
> > > though.
> >
> > It's a fine idea.  Could you
> > repeat your diff against a clean copy of crosstool?
> > You seem to have a lot of extra stuff in your patch.
>
>
> Well the patch also include all the changes added to crosstool.sh (0.30)
> by the NPTL patch provided Sunday.

Right, that's the problem.

> I am not sure how I am suppose to
> provide the patch of a patch. Any guidance?

Run the diff against a clean copy of crosstool with the NPTL
patch.  The resulting diff should show only *your* changes.

> > I might prefer to put those extra options in a shell
> > variable if they get referenced a lot of places,
> > and add a comment explaining why they're needed.
>
> Thant would be fine. Basically the 4 lines above are there to guaranty
> which assembler/linker is used by the generated cross-compiler. Without
> this some bad defaults might be selected (at least on Solaris).

Yes, I know, but that needs to be mentioned in a comment
in the patch.  Including the exact error would be helpful.
I can get that from your earlier post, though,
if you don't feel like digging it up.
- Dan


------
Want more information?  See the CrossGCC FAQ, http://www.objsw.com/CrossGCC/
Want to unsubscribe? Send a note to crossgcc-unsubscribe@sources.redhat.com