This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 0 of 4] Enable both multiple args and args wwith spaces in *_EXTRA_CONFIG


Hi Yann, all,

> The following patchset allows one to enter both multiple arguments
> *and* arguments with spaces in the *_EXTRA_CONFIG config options.
>
> The patchset is basically two-fold:
> - treat variables as arrays (patch 1)
>   - made possible by the fact that bash treats all non-array
>     variables as if they were arrays with a single element.
> - generate proper arrays (path-3)
>   - mangle the .config before feeding it to the biuild scripts
>
> I have only slightly tested this, but it does eem to really
> work pretty good for me. Please shake it before I push. ;-)

It does not work for things like
"${VAR}"
or
one\ word
entered in menuconfig because they become
\"${VAR}\"
and
one\\ word
in .config.

Hence, one escape level has to be removed.

It works with:
	$(SILENT)$(sed) -r -e 's/^([^=]+_ARRAY)="(.*)"$$/\1=( \2 )/;' -e '/^[^=]+_ARRAY=/s/\\(.)/\1/g' $< >$@

Apart from that, this patch set looks good.

Best regards,
BenoÃt

--
For unsubscribe information see http://sourceware.org/lists.html#faq


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]