This is the mail archive of the crossgcc@sourceware.org mailing list for the crossgcc project.

See the CrossGCC FAQ for lots more information.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: eglibc-2_14 patch: Add protection on the __caddr_t typedef in usr/include/sys/types.h to avoid problems when caddr_t is defined.


On Friday 23 December 2011 18:42:28 Jon Diekema wrote:
> On 12/21/2011 05:27 PM, Mike Frysinger wrote:
> > On Wednesday 21 December 2011 14:54:38 Diekema, Jon wrote:
> >> When using ct-ng 1.13.0, the following patch for eglibc-2_14 was needed
> >> for a i686-pc-mingw32-i686-pc-linux-gnu build.
> > 
> > your patch is horribly mangled.  please send with `git send-email`.
> > -mike
> 
> Sorry, let's try this again.

thanks, this one came across fine

now for the question: is this patch correct ?  glibc protects itself against 
redefinition with "__daddr_t_defined".  if you have code that is (wrongly imo) 
defining these core types, then you should also do "#define __daddr_t_defined".
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]