Re: [PATCH] scripts: Select the correct "strip" to strip gdbserver for Canadian build

[Mike Frysinger <vapier at gentoo dot org>]

On Wednesday 19 September 2012 01:48:57 Zhenqiang Chen wrote:
> --- a/scripts/build/internals.sh	Sun Aug 12 07:45:42 2012 -0400
> +++ b/scripts/build/internals.sh	Wed Sep 19 13:11:32 2012 +0800
> 
>          # Strip gdbserver
>          if [ "${CT_GDB_GDBSERVER}" = "y" ]; then
> -           CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args}    \
> -                            ${CT_TARGET}/debug-root/usr/bin/gdbserver
> +            # For Canadian build, we can not run the bin/${CT_TARGET}-strip 
> +            # the build system. But ${CT_TARGET}-strip should be on PATH.
> +            if [ "${CT_CANADIAN}" = "y" ]; then
> +                CT_DoExecLog ALL ${CT_TARGET}-strip ${strip_args}    \
> +                                 ${CT_TARGET}/debug-root/usr/bin/gdbserver
> +            else
> +                CT_DoExecLog ALL bin/${CT_TARGET}-strip ${strip_args}    \
> +                                 ${CT_TARGET}/debug-root/usr/bin/gdbserver
> +            fi

could you set a local variable so that you don't have to copy & paste the 
entire command twice ?
	local cross_strip="bin/${CT_TARGET}-strip"
	[[ ${CT_TARGET} == "y" ]] && cross_strip=${CT_TARGET}-strip
	CT_DoExecLog ALL ${cross_strip} ...
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.