Re: Package review status

[Pavel Tsekov <ptsekov at gmx dot net>]

On Tue, 17 Sep 2002, Ryunosuke Satoh wrote:

> Hi
> 
> >     doxygen (reviewed, 4 votes, Joshua, Lapo, Nicholas and Robert,
> >              package cleanup needed(?))
> > 
> >     astyle  (reviewed, 3 votes, Gareth, Lapo and Pavel,
> >              package cleanup needed)
> > 
> > Ryunosuke, did you tweak your packages already?
> 
> Yes, I did.
> These packages are revised,
> astyle

The astyle still needs some fixing. Quoting from my original review:

    > astyle_1.15.3-src.tar.bz2 => astyle-1.15.3-1-src.tar.bz2
    > astyle_1.15.3.tar.bz2 => astyle-1.15.3-1.tar.bz2
    > /usr/src/astyle_1.15.3 => /usr/src/astyle-1.15.3-1

The -1 is missing from the filename of your revised packages, as well from 
the source directory name. It means first Cygwin release for this package,
then when you fix something else you will increment it to -2, -3, and so on.

    > setup.hint contains a test entry (test: 1.2.17), but i don't recall 
    > having this package as test in the Cygwin net distro, or am I wrong ?

Now the situation is the following -  the setup.hint which is included in 
the root of the astyle-1.15.3-package.tar.gz containst the following line:

    test: 1.2.17

This is obviosly not correct - you're releasing 1.15.3-1 not 1.2.17. I 
suggest you to remove it at all. The same for the setup.hint in the CYGWIN-PATCHES
directory in the -src package. It seem you have changed it there to:

    curr: 1.2.17

Again, remove this line.

    > the source package contains the patch in CYGWIN-PATCHES instead of 
    > the root of the archive.

Now the patch is in the source directory not in the root of the archive. 
The contents of the archive should look like this:

   usr/src/astyle-1.15.3-1
   astyle-1.15.3.patch

Talking about the patch it is wrong. You have to create it outside of the 
source tree i.e. having both the original (/usr/src/astyle-1.15.3) and the 
patched source (/usr/src/astyle-1.15.3-1) in  /usr/src you have to 'cd' to 
/usr/src/ an type this (quoted from the http://cygwin.com/setup.html#setup.hint):

To create the patch file described above, you might run

diff -Nrup astyle-1.15.3 astyle-1.15.3-1 > foo-vendor-release.patch

To apply the generated patch (in reverse; that is, to remove the cygwin 
specific changes from the unpacked -src tarball) the user would run (from 
within the source tree)

patch -R -p1 < ../foo-vendor-release.patch