This is the mail archive of the mailing list for the Cygwin project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Pending setup patches (issue 2)

On Wed, 2003-03-05 at 07:41, Max Bowsher wrote:

> >> * Patch I forwarded from Brian Keener, for adding extra views
> >>

Ok, reviewed again to refresh my memory.

Brian, Why do you change the scroll bar behaviour? Thats orthogonal to
the presence of more views IMO.

Anyway, Max, please commit this.

Brian, if you have time, once this is in, the chooser selection logic

+  else if (chooser->get_view_mode () == PickView::views::PackageKeeps)
+    {
+      for (vector <packagemeta *>::iterator i = db.packages.begin ();
+	   i != db.packages.end (); ++i)
+	{
+	  packagemeta & pkg = **i;
+	  if (pkg.installed && pkg.desired && !pkg.desired.picked() 
+	      && !pkg.desired.sourcePackage().picked())
+	    chooser->insert_pkg (pkg);
+	}
+    }

should be refactored:
else if (choose->get_view_mode() == PickView::views::PackageKeeps)
  insertPackages(db.packages.begin(), db.packages.end(), PackageKeeps::predicateForDisplay());

As a first step.

Waay to much duplicate code there :}. Not a problem you created, just one that the extra views exacerbated.

IF, and only IF you have time, this would be really appreciated.


GPG key available at: <>.

Attachment: signature.asc
Description: This is a digitally signed message part

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]