Re: [PATCH] Cleanup: Close handles in script.cc:run()

[Igor Pechtchanski <pechtcha at cs dot nyu dot edu>]

On Sat, 15 Mar 2003, Max Bowsher wrote:

> Pavel Tsekov wrote:
> > On Sat, 15 Mar 2003, Igor Pechtchanski wrote:
> >
> >> The attached patch closes the unneeded handles in run() in script.cc.
> >> Those handles should be closed according to
> >> <http://msdn.microsoft.com/library/en-us/dllproc/base/createprocess.asp>:
> >
> >    if (b)
> >      WaitForSingleObject (pi.hProcess, INFINITE);
> > +
> > +  CloseHandle(pi.hProcess);
> > +  CloseHandle(pi.hThread);
> >  }
> >
> > I guess it doesn't matter actually, but isn't it better to close the
> > thread handle before the process handle ?!
>
> Probably not better, but it feels nicer.
> Max.

I don't think it matters, but I agree with Max.  New version attached.
	Igor
-- 
				http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_		pechtcha at cs dot nyu dot edu
ZZZzz /,`.-'`'    -.  ;-;;,_		igor at watson dot ibm dot com
     |,4-  ) )-,_. ,\ (  `'-'		Igor Pechtchanski
    '---''(_/--'  `-'\_) fL	a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk!
  -- /usr/games/fortune

Attachment: setup-script-close-handles.patch
Description: Text document