This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Proposed patch - make longopts behave as newbies expect


Robert Collins wrote:
> On Fri, 2003-07-11 at 01:10, Jeremy White wrote:
>> The current setup.exe implementation does not handle longopts
>> in the way that a newbie would expect.  Specifically,
>>   setup.exe --root e:\foo
>> does not work; either
>>   setup.exe -R e:\foo      or
>>   setup.exe --root=e:\foo
>> is required.
>> 
>> This is because the --root, --site, and --override-registry-name
>> StringOptions use the default value that specifies that a value
>> is optional, which, imho, is wrong.
>> 
>>  This patch corrects this, and adds a test program as well.
> 
> Thank you for this. The changes to setup are ok. However, the test
> programs' copyright is -obviously- wrong. Also, I don't see the need for
> an additional user-driven test in this case either - though extending
> testoption.cc would be useful.
> 
> Max, I'm still basically off-the-air - sick - so, could you please
> checkin the setup changes?

No problem, done.

Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]