This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: cabextract review (was Re: Pending package status (14 Jul 2003))


On Tue, Jul 15, 2003 at 03:16:01PM +0100, Elfyn McBratney wrote:
>On Mon, 14 Jul 2003, Elfyn McBratney wrote:
>
>> @ cabextract
>>
>> date   : 27 Jun 2003
>> version: 0.6-1
>> status : not reviewed
>> notes  : http://cygwin.com/ml/cygwin-apps/2003-06/msg00245.html
>>          http://cygwin.com/ml/cygwin-apps/2003-06/msg00244.html
>>          http://cygwin.com/ml/cygwin-apps/2003-06/msg00251.html
>>          http://cygwin.com/ml/cygwin-apps/2003-06/msg00255.html
>> votes  : 4 (Abe, Charles, Igor and Jason)
>> url    : http://tierra.dyndns.org:81/cygwin/cabextract/cabextract-0.6-1-src.tar.bz2
>>          http://tierra.dyndns.org:81/cygwin/cabextract/cabextract-0.6-1.tar.bz2
>
>Jari,
>
>I've reviewed cabextract; following are some observations:
>
>  1) The source package has the build script named `cygbuild.sh', but as source
>     packages are extracted by setup to /usr/src , this might get overwritten.
>     Please rename the script to something like `package-ver-rel.sh'.

Are you saying that this extracts something outside of the source directory itself?
If so, I don't see any reason to pollute /usr/src with anything other than directories.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]