This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup PATCH] Obsolete next_dialog use.


Robert Collins wrote:
> On Wed, 2003-07-23 at 13:31, Gary R. Van Sickle wrote:
>>>
>> 2003-07-22  Gary R. Van Sickle  <g.r.vansickle@worldnet.att.net>
>>
>> * dialog.h (next_dialog): Remove global variable, obsolete.
>> (do_fromcwd): Change function declaration.
>> (NEXT): Remove obsolete macro.
>> * download.cc (do_download_thread): Add next_dialog as return
>> parameter (return by reference).
>> (do_download_reflector): Call do_download_thread() with third
>> parameter.  Call Progress.PostMessage() with returned value.
>> (context): Increase context to three HANDLE's.
>> (do_download): Initialize new context member.
>> * fromcwd.cc (do_fromcwd): Change return type to bool.  Eliminate
>> use of next_dialog, return true or false instead.
>> * ini.cc (do_ini_thread): Add next_dialog as return
>> parameter (return by reference).
>> (do_ini_thread_reflector): Call do_ini_thread with third parameter.
>> Call Progress.PostMessage() with returned value.
>> (context): Increase context to three HANDLE's.
>> (do_ini): Initialize new context member.
>> * localdir.cc (LocalDirPage::OnNext): Use do_fromcwd()'s return
>> value instead of next_dialog.
>> * main.cc (next_dialog): Remove obsolete global variable.
>> (main): Remove initialization of next_dialog.
>
> This isn't approved. I need to review it.

Of course.

The patch I posted is the simple part of this change - entirely deletions of
what I believe to be no-ops. It is also standalone. If you could review that
first, I will pre-review Gary's followup patch above.

Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]