This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [setup PATCH] Obsolete next_dialog use.


Gary R. Van Sickle wrote:
> Looks good, but let's do it up like they do downtown and wipe next_dialog
off
> the face of the earth!  Add the attached patch to yours, and with our
combined
> might we shall be through with it FOREVER!!!  BAAHAHHAHAHHAAAA!!!!
>
> Single non-mega concept, pinky-swear. ;-)

Indeed, it is. However, a few nits I'm picking:

1) The 'context's. Don't cast when you don't have to. Turn the contexts into
structs.

2) The second hunk of your main.cc was already in my patch.

3) Your ChangeLog says "return by reference". Why not actually use
references, not pointers.

4) fromcwd.cc, this comment "// Didn't find it." is too obvious to be
needed, it's just clutter.

Max.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]