This is the mail archive of the cygwin-apps@cygwin.com mailing list for the Cygwin project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Gary: LogFile::Exit/IDD_SPLASH changes.


Issue: LogFile::Exit **REVERSION REQUESTED**
        * LogFile.cc (LogFile::exit): Only exit() on error, otherwise return
        to caller.
        * LogFile.h (LogFile::exit): Remove noreturn attribute.
        * LogSingleton.h (LogSingleton::exit): Remove noreturn attribute.
        * main.cc (main): Change some comments.

Issue: Minor res.rc changes **REVERSION REQUESTED**
        * res.rc (IDD_SPLASH): Move icon.  Change commented-out
        "white box" static control to a black invisible one.


Gary, please revert these changes, OR engage in discussion about them.

They are cluttering up your diff.txt, they have absolutely no user-visible
effect, and (as far as I can see) no developer benefit.


Max.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]